Ensure custom types support pickling. #491
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ragnard
force-pushed
the
support-pickle
branch
4 times, most recently
from
f7d6099 to
b7b0fa4
Compare
ragnard
changed the title
Previously `NamedRowTuple` did not roundtrip successfully. Added tests for all custom types. Fixes trinodb#490.
ragnard
force-pushed
the
support-pickle
branch
from
b7b0fa4 to
2420abf
Compare
hashhar
approved these changes
Nov 20, 2024
|
@damian3031 can you also take a look? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure
NamedRowTuplepickleroundtrips successfully.Added tests for all custom types.
Fixes #490.
Description
Implement necessary
picklemethods to ensure type can be pickled/unpickled correctly.Non-technical explanation
Support pickle serialization/deserialization for rows.
Release notes
( ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
(x) Release notes are required, with the following suggested text: