Skip to content

Conversation

mdesmet
Copy link
Contributor

@mdesmet mdesmet commented Nov 12, 2024

Description

Currently the function to parse the authorization header doesn't support urls containing parameters. This PR addresses this.

Non-technical explanation

Release notes

( ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
(x) Release notes are required, with the following suggested text:

* Fix authentication parsing to allow urls containing url parameters

Copy link
Member

@hashhar hashhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good % question about whitespace

@mdesmet mdesmet force-pushed the fix/oauth_redirect_server branch 2 times, most recently from 4f4c40a to 7c689fa Compare November 18, 2024 14:15
@mdesmet mdesmet force-pushed the fix/oauth_redirect_server branch from 7c689fa to e62ee81 Compare November 19, 2024 17:37
@hashhar hashhar merged commit fe1022b into trinodb:master Nov 20, 2024
12 checks passed
@hashhar hashhar deleted the fix/oauth_redirect_server branch November 20, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants