Skip to content

Update pre-commit configuration #500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Update pre-commit configuration #500

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 17 additions & 12 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,29 +1,34 @@
repos:
- repo: "https://github.com/PyCQA/flake8"
rev: "7.0.0"
rev: "7.1.1"
hooks:
- id: "flake8"
name: "Python: analysis"

- repo: "https://github.com/pre-commit/mirrors-mypy"
rev: "v1.8.0"
rev: "v1.13.0"
hooks:
- id: "mypy"
name: "Python: types"

- repo: https://github.com/pycqa/isort
- repo: "https://github.com/PyCQA/isort"
rev: "5.13.2"
hooks:
- id: isort
args: [ "--profile", "black"]
- id: "isort"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might become a problem in the future since pre-commit clean && pre-commit run --all gives a warning:

[INFO] Initializing environment for https://github.com/PyCQA/isort.
[WARNING] repo `https://github.com/PyCQA/isort` uses deprecated stage names (commit, merge-commit, push) which will be removed in a future version.  Hint: often `pre-commit autoupdate --repo https://github.com/PyCQA/isort` will fix this.  if it does not -- consider reporting an issue to that repo.

Unfortunately the project haven’t seen updates for almost a year. There is an alternative though.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for bringing this up. Would you like to submit follow-up PR (or separate commit here) to migrate from isort to that?

Copy link
Member Author

@arturdryomov arturdryomov Dec 12, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure thing, I’ll check it out as a separate PR.

name: "Python: imports"
args: ["--profile", "black"]

- repo: https://github.com/pre-commit/pre-commit-hooks
rev: "v4.5.0"
- repo: "https://github.com/pre-commit/pre-commit-hooks"
rev: "v5.0.0"
hooks:
- id: check-yaml
args: [--unsafe]
- id: end-of-file-fixer
- id: trailing-whitespace
- id: "check-yaml"
name: "YAML: syntax"
args: ["--unsafe"]
- id: "end-of-file-fixer"
name: "All: newlines at EOF"
- id: "trailing-whitespace"
name: "All: no trailing whitespaces"
exclude_types:
- "markdown"
- id: check-case-conflict
- id: "check-case-conflict"
name: "All: case-insensitive filesystem conflicts"
Loading