Add missing type annotations for the "ClientSession" class #502
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hashhar
approved these changes
Dec 13, 2024
Comment on lines
+127
to
+128
| self._object_lock = threading.Lock() | ||
| self._prepared_statements: Dict[str, str] = {} |
There was a problem hiding this comment.
No, I moved them since they are not passed as arguments and it’s easier to distinguish logical difference. Can move back if needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type annotations for the
client.ClientSessionclass based on constructor arguments and in-constructor behavior.Release notes
Release notes are required, with the following suggested text: