Skip to content

Fix test_segments_cursor #565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2025
+12 −2
Merged

Fix test_segments_cursor #565

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions tests/integration/test_dbapi_integration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,9 @@
import trino
from tests.integration.conftest import trino_version
from trino import constants
from trino.client import InlineSegment
from trino.client import SegmentIterator
from trino.client import SpooledSegment
from trino.dbapi import Cursor
from trino.dbapi import DescribeOutput
from trino.dbapi import TimeBoundLRUCache
Expand Down Expand Up @@ -1883,9 +1885,17 @@ def test_segments_cursor(trino_connection):
row_mapper = RowMapperFactory().create(columns=cur._query.columns, legacy_primitive_types=False)
total = 0
for segment in segments:
assert isinstance(segment.segment, (InlineSegment, SpooledSegment)), (
f"Expected InlineSegment or SpooledSegment, got {type(segment.segment)}"
)
assert segment.encoding == trino_connection._client_session.encoding
assert isinstance(segment.segment.uri, str), f"Expected string for uri, got {segment.segment.uri}"
assert isinstance(segment.segment.ack_uri, str), f"Expected string for ack_uri, got {segment.segment.ack_uri}"
if isinstance(segment.segment, SpooledSegment):
assert isinstance(segment.segment.uri, str), (
f"Expected string for uri, got {type(segment.segment.uri)}"
)
assert isinstance(segment.segment.ack_uri, str), (
f"Expected string for ack_uri, got {type(segment.segment.ack_uri)}"
)
total += len(list(SegmentIterator(segment, row_mapper)))
assert total == 300875, f"Expected total rows 300875, got {total}"

Expand Down