Fix domain-wide delegation for Google Sheets connector #26501
Conversation
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
| @@ -295,7 +295,7 @@ private static Credential credentialFromStream(InputStream inputStream, Optional | |||
| throws IOException | |||
| { | |||
| GoogleCredential credential = GoogleCredential.fromStream(inputStream).createScoped(SCOPES); | |||
| delegatedUserEmail.ifPresent(credential::createDelegated); | |||
| credential = delegatedUserEmail.map(credential::createDelegated).orElse(credential); | |||
|
Hello! I subscribed to the CLA but I don't have any feedback. Is it okay? |
|
@radium226 the CLA process is handled manually and usually takes 1–2 weeks, so no need to worry |
plugin/trino-google-sheets/src/main/java/io/trino/plugin/google/sheets/SheetsClient.java
Outdated
Show resolved
Hide resolved
…e/sheets/SheetsClient.java Co-authored-by: chenjian2664 <[email protected]>
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
| @@ -295,7 +295,7 @@ private static Credential credentialFromStream(InputStream inputStream, Optional | |||
| throws IOException | |||
| { | |||
| GoogleCredential credential = GoogleCredential.fromStream(inputStream).createScoped(SCOPES); | |||
| delegatedUserEmail.ifPresent(credential::createDelegated); | |||
| return delegatedUserEmail.map(credential::createDelegated).orElse(credential); | |||
| return credential; | |||
There was a problem hiding this comment.
This line becomes unreachable
Description
I wasn't able to make the domain-wide delegation works, and I think it's because the
credentialsis not reassigned, and thecreateDelegatedreturns a new instance. See thisAdditional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: