Remove CatalogHandle from SPI #26520
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
iceberg
dain
force-pushed
the
catalog-handle-cleanup
branch
from
dd08453 to
5117552
Compare
electrum
approved these changes
Sep 1, 2025
core/trino-spi/src/main/java/io/trino/spi/connector/CatalogVersion.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/connector/CoordinatorDynamicCatalogManager.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/connector/CoordinatorDynamicCatalogManager.java
Outdated
Show resolved
Hide resolved
dain
force-pushed
the
catalog-handle-cleanup
branch
from
5117552 to
7a28ecf
Compare
dain
force-pushed
the
catalog-handle-cleanup
branch
from
7a28ecf to
b133a12
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The SPI does not need (or really use) CatalogHandle, and instead the CatalogName and CatalogVersion can be used.
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(X) Release notes are required, with the following suggested text: