Reenable HTTP/2 for internal communication

[wendigo]

Lower number of TCP/IP connections for HTTP/2

Description

Additional context and related issues

Release notes

( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text:

## General
*  Enable HTTP/2 for internal communication ({issue}`issuenumber`)

Summary by Sourcery

Enable HTTP/2 for internal Trino communication by default and adjust connection limits accordingly

Enhancements:

• Enable HTTP/2 for internal communication by default
• Reduce default max connections per server from 250 to 64 when HTTP/2 is enabled
• Add http2Enabled default value to InternalCommunicationConfig
• Update tests to expect the new HTTP/2 default and explicit configuration mappings

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR reenables HTTP/2 for internal communication by setting the default to enabled in the InternalCommunicationConfig, updating the internal HTTP client setup to adjust maxConnectionsPerServer based on the HTTP/2 flag, and revising tests to align with the new defaults and explicit property mappings.

Sequence diagram for internal HTTP client configuration based on HTTP/2 flag

sequenceDiagram
participant CoordinatorModule
participant InternalCommunicationConfig
participant HttpClientConfig

CoordinatorModule->>InternalCommunicationConfig: buildConfigObject()
InternalCommunicationConfig-->>CoordinatorModule: http2Enabled (default true)
CoordinatorModule->>HttpClientConfig: withConfigDefaults()
alt HTTP/2 enabled
    CoordinatorModule->>HttpClientConfig: setMaxConnectionsPerServer(64)
else HTTP/2 disabled
    CoordinatorModule->>HttpClientConfig: setMaxConnectionsPerServer(250)
end

Loading

Class diagram for updated InternalCommunicationConfig

classDiagram
class InternalCommunicationConfig {
  - String sharedSecret
  - boolean http2Enabled = true
  - boolean httpsRequired
  - String keyStorePath
  - String keyStorePassword
}

Loading

File-Level Changes

Change	Details	Files
Set HTTP/2 enabled by default in internal communication config	Initialize http2Enabled to true in InternalCommunicationConfig Update test default expectations to http2Enabled=true Adjust explicit property mapping tests to reflect http2Enabled=false override	core/trino-main/src/main/java/io/trino/server/InternalCommunicationConfig.java core/trino-main/src/test/java/io/trino/server/TestInternalCommunicationConfig.java
Make internal HTTP client maxConnectionsPerServer dynamic based on HTTP/2 flag	Inject InternalCommunicationConfig into CoordinatorModule Use 64 max connections when HTTP/2 is enabled, otherwise 250	core/trino-main/src/main/java/io/trino/server/CoordinatorModule.java

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey there - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[starburstdata-automation]

Started benchmark workflow for this PR with test type = iceberg/sf1000_parquet_part.

Building Trino finished with status: success
Benchmark finished with status: success
Comparing results to the static baseline values, follow above workflow link for more details/logs.
Status message: NO Regression found.
Benchmark Comparison to the closest run from Master: Report

[starburstdata-automation]

Started benchmark workflow for this PR with test type = iceberg/sf1000_parquet_unpart.

Building Trino finished with status: success
Benchmark finished with status: success
Comparing results to the static baseline values, follow above workflow link for more details/logs.
Status message: NO Regression found.
Benchmark Comparison to the closest run from Master: Report