WIP: HTTP/2 + VirtualThreads #26896
Open
WIP: HTTP/2 + VirtualThreads #26896
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lower number of TCP/IP connections for HTTP/2
Reviewer's guide (collapsed on small PRs)Reviewer's GuideInternal communication now defaults to HTTP/2 with adjusted connection limits and uses virtual threads for both server HTTP listeners and internal HTTP clients. Sequence diagram for HTTP client configuration with HTTP/2 and virtual threadssequenceDiagram
participant CoordinatorModule
participant InternalCommunicationConfig
participant HttpClientConfig
CoordinatorModule->>InternalCommunicationConfig: buildConfigObject()
CoordinatorModule->>HttpClientConfig: withConfigDefaults()
HttpClientConfig->>InternalCommunicationConfig: isHttp2Enabled()
alt HTTP/2 enabled
HttpClientConfig->>HttpClientConfig: setMaxConnectionsPerServer(64)
else HTTP/2 not enabled
HttpClientConfig->>HttpClientConfig: setMaxConnectionsPerServer(250)
end
HttpClientConfig->>HttpClientConfig: setHttp2Enabled()
HttpClientConfig->>HttpClientConfig: setUseVirtualThreads(true)
Class diagram for updated InternalCommunicationConfig and HttpClientConfigclassDiagram
class InternalCommunicationConfig {
- String sharedSecret
- boolean http2Enabled = true
- boolean httpsRequired
- String keyStorePath
- String keyStorePassword
}
class HttpClientConfig {
- boolean http2Enabled
- boolean useVirtualThreads
- Duration idleTimeout
- Duration requestTimeout
- int maxConnectionsPerServer
}
InternalCommunicationConfig --> HttpClientConfig : configures
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
Started benchmark workflow for this PR with test type =
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey there - I've reviewed your changes and they look great!
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `core/trino-main/src/main/java/io/trino/server/CoordinatorModule.java:365-368` </location>
<code_context>
config.setIdleTimeout(new Duration(60, SECONDS));
config.setRequestTimeout(new Duration(20, SECONDS));
- config.setMaxConnectionsPerServer(250);
+ if (internalCommunicationConfig.isHttp2Enabled()) {
+ config.setMaxConnectionsPerServer(64);
+ }
+ else {
+ config.setMaxConnectionsPerServer(250);
+ }
</code_context>
<issue_to_address>
**issue (performance):** Connection limits are now conditional on HTTP/2, which may affect scaling.
Verify that 64 connections per server is adequate for your HTTP/2 workloads, or consider making this limit configurable to better support varying traffic demands.
</issue_to_address>
### Comment 2
<location> `core/trino-main/src/test/java/io/trino/server/TestInternalCommunicationConfig.java:35` </location>
<code_context>
assertRecordedDefaults(recordDefaults(InternalCommunicationConfig.class)
.setSharedSecret(null)
- .setHttp2Enabled(false)
+ .setHttp2Enabled(true)
.setHttpsRequired(false)
.setKeyStorePath(null)
</code_context>
<issue_to_address>
**suggestion (testing):** Test for default value of http2Enabled updated to true.
Also add a test case for when http2Enabled is unset to confirm the default value is correctly applied.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
core/trino-main/src/test/java/io/trino/server/TestInternalCommunicationConfig.java
Show resolved
Hide resolved
|
Started benchmark workflow for this PR with test type =
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Additional context and related issues
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:
Summary by Sourcery
Enable HTTP/2 by default and activate virtual threads for internal HTTP communication and the HTTP server, adjust connection pool settings accordingly, and update tests to reflect new defaults.
New Features:
Enhancements:
Tests: