Reuse IcebergPageSourceProvider across splits for a scan in Lakehouse#28507
Open
raunaqmorarka wants to merge 1 commit intotrinodb:masterfrom
Open
Reuse IcebergPageSourceProvider across splits for a scan in Lakehouse#28507raunaqmorarka wants to merge 1 commit intotrinodb:masterfrom
raunaqmorarka wants to merge 1 commit intotrinodb:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the Lakehouse connector’s ConnectorPageSourceProviderFactory to reuse a single Iceberg page source provider instance across splits within the same scan, enabling reuse of equality delete state (and associated performance/memory improvements) during Iceberg reads.
Changes:
- Wrap
createPageSourceProvider()with a statefulConnectorPageSourceProviderthat caches the chosen delegate provider. - Reuse the same Iceberg page source provider across multiple
createPageSourcecalls (splits) to allow equality delete reuse. - Add
getMemoryUsage()delegation with a0value before any page source is created.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...no-lakehouse/src/main/java/io/trino/plugin/lakehouse/LakehousePageSourceProviderFactory.java
Outdated
Show resolved
Hide resolved
...no-lakehouse/src/main/java/io/trino/plugin/lakehouse/LakehousePageSourceProviderFactory.java
Show resolved
Hide resolved
ebyhr
approved these changes
Mar 3, 2026
chenjian2664
approved these changes
Mar 3, 2026
This is necessary to reuse equality deletes in an iceberg scan across splits in a worker
001b722 to
3394553
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...no-lakehouse/src/main/java/io/trino/plugin/lakehouse/LakehousePageSourceProviderFactory.java
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is necessary to reuse equality deletes in an iceberg scan across splits in a worker
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text: