Skip to content

Avoid table lines with same values order to change when ordering using descending way #250#251

Open
sdiemer wants to merge 1 commit intotristen:mainfrom
UbiCastTeam:issue250-fix-descending-ordering-on-refresh
Open

Avoid table lines with same values order to change when ordering using descending way #250#251
sdiemer wants to merge 1 commit intotristen:mainfrom
UbiCastTeam:issue250-fix-descending-ordering-on-refresh

Conversation

@sdiemer
Copy link

@sdiemer sdiemer commented Nov 19, 2025

No description provided.

@sdiemer
Copy link
Author

sdiemer commented Nov 19, 2025

Pull request for issue #250.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 @sdiemer apologies on the delay reviewing this. Can you add a test that asserts this behavior you reported in #250 is fixed? I am not quite tracking the issue exactly and I am wary of modifying the logic here without a clearer understanding and a unit test to avoid regression in the future.

Copy link
Owner

@tristen tristen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment in src/tablesort.js

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to add the output of npm run build to this PR. I can include this in a dedicated release that will include other changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants