Open
Conversation
The current setup for the libgrpcclient.ldscript file may work fine with GNU make at the moment, but confuses [Ninja](https://ninja-build.org/). This will fix the build for Ninja, while hopefully letting the rest of the build work when using the GNU Makefile generator.
|
Just saw this MR after creating #836 . What needs update is the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current setup for the libgrpcclient.ldscript file may work fine with GNU make at the moment, but confuses Ninja. This will fix the build for Ninja, while hopefully letting the rest of the build work when using the GNU Makefile generator.