Conversation
statiraju
previously approved these changes
Aug 21, 2024
tanmayv25
previously approved these changes
Aug 21, 2024
yinggeh
dismissed stale reviews from tanmayv25 and statiraju
The base branch was changed.
yinggeh
force-pushed
the
yinggeh-fix-windows-build
branch
2 times, most recently
from
17664da to
c7ef453
Compare
Contributor
|
It must went to the |
yinggeh
force-pushed
the
yinggeh-fix-windows-build
branch
from
c7ef453 to
980963a
Compare
Contributor
Author
Reverted and set this PR to merge to main. |
tanmayv25
approved these changes
Aug 21, 2024
Contributor
Author
|
@tanmayv25 Should we consider auto-generate |
yinggeh
added a commit
that referenced
this pull request
Aug 21, 2024
mc-nv
pushed a commit
that referenced
this pull request
Aug 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does the PR do?
Fix windows build
New C APIs were added in #386 but some were not added in to core/src/tritonserver_stub.cc.
Checklist
<commit_type>: <Title>Commit Type:
Check the conventional commit type
box here and add the label to the github PR.
Related PRs:
n/a
Where should the reviewer start?
n/a
Test plan:
n/a
17686949
Caveats:
n/a
Background
n/a
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)
n/a