Merged
Conversation
This was referenced Aug 7, 2024
Merged
Contributor
|
I think we need general tests for this on python backend as well |
Contributor
|
+1 on the test. Also I think would be great if we can add the documentation for the new type of metrics: https://github.com/triton-inference-server/python_backend/tree/main/examples/custom_metrics |
rmccorm4
reviewed
Aug 7, 2024
Tabrizian
reviewed
Aug 13, 2024
11 tasks
…hon_backend into yinggeh-DLIS-7113-support-histogram-metric-type
Contributor
Author
Updated. See commit |
GuanLuo
approved these changes
Aug 16, 2024
krishung5
approved these changes
Aug 16, 2024
Tabrizian
approved these changes
Aug 16, 2024
This was referenced Aug 16, 2024
Closed
Merged
mc-nv
pushed a commit
that referenced
this pull request
Aug 19, 2024
mc-nv
added a commit
that referenced
this pull request
Aug 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does the PR do?
Support histogram metric type and its functions.
Checklist
<commit_type>: <Title>Commit Type:
Check the conventional commit type
box here and add the label to the github PR.
Related PRs:
triton-inference-server/vllm_backend#56
triton-inference-server/core#386
triton-inference-server/server#7525
Where should the reviewer start?
n/a
Test plan:
n/a
17487728
Caveats:
n/a
Background
Customer requested histogram metrics from vLLM.
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)
n/a