Skip to content

fix: Improve error handling for Python backend model initialization failures #408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Aug 7, 2025
Merged

fix: Improve error handling for Python backend model initialization failures #408

Changes from 3 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
44cb1f3
Update
pskiran1 Jul 21, 2025
e5b2088
Update
pskiran1 Jul 21, 2025
76aebcf
Undo shm chnages
pskiran1 Jul 23, 2025
e62e582
Fix shm issue
pskiran1 Aug 3, 2025
a960608
Update
pskiran1 Aug 4, 2025
4fdb468
Update timeout
pskiran1 Aug 5, 2025
a26c928
Update
pskiran1 Aug 6, 2025
386f27a
Update
pskiran1 Aug 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/stub_launcher.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,7 +301,8 @@ StubLauncher::Launch()
// monitoring thread may take longer which can make the server process think
// that the stub process is unhealthy and return early. Waiting until the
// health thread is spawn would make sure would prevent this issue.
parent_message_queue_->Pop();
bi::managed_external_buffer::handle_t message;
RETURN_IF_ERROR(ReceiveMessageFromStub(message));

if (stub_process_kind_ == "AUTOCOMPLETE_STUB") {
try {
Expand Down Expand Up @@ -458,7 +459,8 @@ StubLauncher::Launch()
// monitoring thread may take longer which can make the server process think
// that the stub process is unhealthy and return early. Waiting until the
// health thread is spawn would prevent this issue.
parent_message_queue_->Pop();
bi::managed_external_buffer::handle_t message;
RETURN_IF_ERROR(ReceiveMessageFromStub(message));

if (stub_process_kind_ == "AUTOCOMPLETE_STUB") {
try {
Expand Down
Loading