Skip to content

ci: Adding tests for numpy>=2 #7756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Nov 1, 2024
Merged

ci: Adding tests for numpy>=2 #7756

Changes from 3 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
70e08bc
Modify numpy, torch, torchvision versions for examples subtest
KrishnanPrash Oct 30, 2024
fb3e0f8
spacing
KrishnanPrash Oct 30, 2024
aa3059a
spacing
KrishnanPrash Oct 30, 2024
aad7554
removing unecessary numpy uninstall + reinstall lower version
KrishnanPrash Oct 31, 2024
ba5c84d
installing torch w cuda dependencies for non-windows and non-jetson envs
KrishnanPrash Oct 31, 2024
598fade
Merge branch 'main' into kprashanth-numpy2-test
KrishnanPrash Oct 31, 2024
ba904a2
Update qa/L0_backend_python/examples/test.sh
KrishnanPrash Nov 1, 2024
ec3bccd
formatting
KrishnanPrash Nov 1, 2024
00fe74a
Installing lower version for python 3.8
KrishnanPrash Nov 1, 2024
9fc4c55
comments
KrishnanPrash Nov 1, 2024
b58ff56
Merge branch 'main' into kprashanth-numpy2-test
KrishnanPrash Nov 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions qa/L0_backend_python/examples/test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,10 +38,12 @@ rm -fr *.log python_backend/

# Install torch
pip3 uninstall -y torch
pip3 uninstall -y numpy
pip3 install "numpy>=2"
if [ "$TEST_JETSON" == "0" ] && [[ ${TEST_WINDOWS} == 0 ]]; then
pip3 install torch==2.0.0+cu117 -f https://download.pytorch.org/whl/torch_stable.html torchvision==0.15.0+cu117
pip3 install torch==2.5.0 -f https://download.pytorch.org/whl/torch_stable.html torchvision==0.20.0
else
pip3 install torch==2.0.0 -f https://download.pytorch.org/whl/torch_stable.html torchvision==0.15.0
pip3 install torch==2.5.0 -f https://download.pytorch.org/whl/torch_stable.html torchvision==0.20.0
Copy link
Contributor

@rmccorm4 rmccorm4 Oct 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that the if condition installed a +cu version, and the else did not. In your change you have both if/else installing the same thing. Please either match the install pattern with the correct +cuXXX variant, or double check whether this if/else is required if not. CC @fpetrini15 who might know a bit more about the if/else split here.

Copy link
Contributor

@fpetrini15 fpetrini15 Oct 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rmccorm4 I think this is a code segment we discussed a few months back. It seems like since Jacky has fixed my original error here; 23a6c21. I think for non-Jetson Linux tests, we want to continue installing the cuda-enabled version. That said, these tests were passing fine even with my logical error from months ago, so it's unclear to me what we achieve by installing the cuda-enabled version.

Copy link
Contributor

@rmccorm4 rmccorm4 Oct 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this doesn't break windows/jetson, I'm happy to keep it. If it might, we could also try making the change only on the linux non-jetson block. ex:

if not jetson/windows:
  pip install numpy 2
  pip install torch 2.5
else: # if windows/jetson
  pip install numpy 1
  pip install torch 2.0
fi

Let me know if you have a preference for minimal blast radius @fpetrini15

Copy link
Contributor

@fpetrini15 fpetrini15 Oct 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should align with the original intention of the script and install the cuda-enabled version.

CC @Tabrizian if you have any insight into why we preferred it originally?

Copy link
Member

@Tabrizian Tabrizian Oct 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe PyTorch with CUDA was not supported on Jetson. We also don't support GPU tensors on Jetson with Python backend so it could be related to that.

fi

# Install `validators` for Model Instance Kind example
Expand Down Expand Up @@ -440,4 +442,7 @@ else
echo -e "\n***\n*** Example verification test FAILED.\n***"
fi

pip3 uninstall -y numpy
pip3 install "numpy<2"
Copy link
Contributor Author

@KrishnanPrash KrishnanPrash Oct 31, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In L0_backend_python, the way examples/test.sh is called is along the lines of:

    setup_virtualenv

    set +e
    (cd ${TEST} && bash -ex test.sh)

    if [ $? -ne 0 ]; then
        echo "Subtest ${TEST} FAILED"
        RET=1
    fi
    set -e

    deactivate_virtualenv

So re-installing a lower version of numpy is unnecessary here because the virtualenv created for the examples subtest is not re-used for future subtests.


exit $RET
Loading