Skip to content

ci: Fix L0_lifecycle server shutdown#7933

Merged
kthui merged 1 commit intomainfrom
jacky-lifecycle-shutdown
Jan 14, 2025
Merged

ci: Fix L0_lifecycle server shutdown#7933
kthui merged 1 commit intomainfrom
jacky-lifecycle-shutdown

Conversation

@kthui
Copy link
Contributor

@kthui kthui commented Jan 14, 2025

What does the PR do?

There are four tests in L0_lifecycle that the server shutdown is triggered by the py test, which may not return by the time the server completes its shutdown, causing the failure that the test script is trying to shutdown a stopped server.

Checklist

  • PR title reflects the change and is of format <commit_type>: <Title>
  • Changes are described in the pull request.
  • Related issues are referenced.
  • Populated github labels field
  • Added test plan and verified test passes.
  • Verified that the PR passes existing CI.
  • Verified copyright is correct on all changed files.
  • Added succinct git squash message before merging ref.
  • All template sections are filled out.
  • Optional: Additional screenshots for behavior/output changes with before/after.

Commit Type:

Check the conventional commit type
box here and add the label to the github PR.

  • build
  • ci
  • docs
  • feat
  • fix
  • perf
  • refactor
  • revert
  • style
  • test

Related PRs:

N/A

Where should the reviewer start?

N/A

Test plan:

L0_lifecycle should pass.

  • CI Pipeline ID: 22497034

Caveats:

N/A

Background

N/A

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

N/A

@kthui kthui added the PR: ci Changes to our CI configuration files and scripts label Jan 14, 2025
@kthui kthui self-assigned this Jan 14, 2025
@kthui kthui requested a review from GuanLuo January 14, 2025 19:32
@kthui kthui marked this pull request as ready for review January 14, 2025 19:32
@kthui kthui requested a review from rmccorm4 January 14, 2025 19:32
@kthui kthui requested a review from rmccorm4 January 14, 2025 19:52
@kthui kthui merged commit 71ee05c into main Jan 14, 2025
3 checks passed
@kthui kthui deleted the jacky-lifecycle-shutdown branch January 14, 2025 22:15
kthui added a commit that referenced this pull request Jan 14, 2025
pvijayakrish pushed a commit that referenced this pull request Jan 15, 2025
pvijayakrish pushed a commit that referenced this pull request Jan 15, 2025
kthui added a commit that referenced this pull request Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: ci Changes to our CI configuration files and scripts

Development

Successfully merging this pull request may close these issues.

2 participants