Merged
Conversation
rmccorm4
reviewed
Jan 14, 2025
rmccorm4
approved these changes
Jan 14, 2025
kthui
added a commit
that referenced
this pull request
Jan 14, 2025
pvijayakrish
pushed a commit
that referenced
this pull request
Jan 15, 2025
pvijayakrish
pushed a commit
that referenced
this pull request
Jan 15, 2025
pvijayakrish
pushed a commit
that referenced
this pull request
Jan 15, 2025
kthui
added a commit
that referenced
this pull request
Jan 17, 2025
mc-nv
pushed a commit
that referenced
this pull request
Jan 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does the PR do?
There are four tests in L0_lifecycle that the server shutdown is triggered by the py test, which may not return by the time the server completes its shutdown, causing the failure that the test script is trying to shutdown a stopped server.
Checklist
<commit_type>: <Title>Commit Type:
Check the conventional commit type
box here and add the label to the github PR.
Related PRs:
N/A
Where should the reviewer start?
N/A
Test plan:
L0_lifecycle should pass.
Caveats:
N/A
Background
N/A
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)
N/A