test: Add tests for response parameters support for BLS in Python backend #7987
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
20 tasks
ziqifan617
added
PR: test
kthui
reviewed
Feb 5, 2025
There was a problem hiding this comment.
Nice work on your first test case!
Two things I think we can enhance on:
- A test case when the BLS composing model is also decoupled.
- The BLS test may reuse the
response_paremeters_test.pyif it only differs slightly from the newresponse_parameters_bls_test.py, i.e. model names.
krishung5
reviewed
Feb 5, 2025
ziqifan617
force-pushed
the
ziqif-bls-resp-params
branch
from
8b2f2de to
bc8f539
Compare
kthui
approved these changes
Feb 6, 2025
pvijayakrish
pushed a commit
that referenced
this pull request
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do?
Add tests for response parameters support for BLS in Python backend
Checklist
<commit_type>: <Title>Commit Type:
Check the conventional commit type
box here and add the label to the github PR.
Related PRs:
triton-inference-server/python_backend#395
Where should the reviewer start?
Start with test_setting_three_element_response_parameters test case first to get a sense on the feature, and then move on to other test cases, and finish with test_setting_response_parameters_decoupled test case.
Test plan:
Caveats:
NA
Background
NA
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)
https://jirasw.nvidia.com/browse/DLIS-7520