Skip to content

[build]: Add rt_base_image parameter to differentiate triton build base image and runtime base image #8064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

[build]: Add rt_base_image parameter to differentiate triton build base image and runtime base image #8064

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
3750090
Add runtime image for final container build
nv-tusharma Mar 5, 2025
571a6d7
Remove build_base parameter
nv-tusharma Mar 5, 2025
d145aea
Set rt_base image as local variable for create_dockerfile_* function
nv-tusharma Mar 10, 2025
a48c900
Add git as a dependency for QA images
nv-tusharma Mar 11, 2025
d6e151b
Revert "Add git as a dependency for QA images"
nv-tusharma Mar 11, 2025
b655f0d
Syntax fixes to pass pre-commit check
nv-tusharma Mar 12, 2025
f2b260e
Fix minor formatting issues
nv-tusharma Mar 12, 2025
87901c7
Minor syntax fix to pass pre-commit check
nv-tusharma Mar 12, 2025
741135a
Rename rt_base to runtime var
nv-tusharma Mar 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 30 additions & 5 deletions build.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1220,8 +1220,20 @@ def create_dockerfile_cibase(ddir, dockerfile_name, argmap):


def create_dockerfile_linux(
ddir, dockerfile_name, argmap, backends, repoagents, caches, endpoints
ddir,
dockerfile_name,
argmap,
backends,
repoagents,
caches,
endpoints,
runtime_image=None,
):
base_image = argmap["BASE_IMAGE"]
# If runtime base image is provided, use it as the base image
if runtime_image:
base_image = runtime_image

df = """
ARG TRITON_VERSION={}
ARG TRITON_CONTAINER_VERSION={}
Expand All @@ -1230,7 +1242,7 @@ def create_dockerfile_linux(
""".format(
argmap["TRITON_VERSION"],
argmap["TRITON_CONTAINER_VERSION"],
argmap["BASE_IMAGE"],
base_image,
)

# PyTorch and TensorFlow backends need extra CUDA and other
Expand Down Expand Up @@ -1642,8 +1654,12 @@ def change_default_python_version_rhel(version):


def create_dockerfile_windows(
ddir, dockerfile_name, argmap, backends, repoagents, caches
ddir, dockerfile_name, argmap, backends, repoagents, caches, runtime_image=None
):
base_image = argmap["BASE_IMAGE"]
# If runtime base image is provided, use it as the base image
if runtime_image:
base_image = runtime_image
df = """
ARG TRITON_VERSION={}
ARG TRITON_CONTAINER_VERSION={}
Expand All @@ -1666,7 +1682,7 @@ def create_dockerfile_windows(
""".format(
argmap["TRITON_VERSION"],
argmap["TRITON_CONTAINER_VERSION"],
argmap["BASE_IMAGE"],
base_image,
)
df += """
WORKDIR /opt
Expand Down Expand Up @@ -1752,6 +1768,7 @@ def create_build_dockerfiles(
backends,
repoagents,
caches,
images.get("runtime"),
)
else:
create_dockerfile_linux(
Expand All @@ -1762,6 +1779,7 @@ def create_build_dockerfiles(
repoagents,
caches,
endpoints,
images.get("runtime"),
)

# Dockerfile used for the creating the CI base image.
Expand Down Expand Up @@ -2940,7 +2958,14 @@ def enable_all():
)
fail_if(
parts[0]
not in ["base", "gpu-base", "pytorch", "tensorflow", "tensorflow2"],
not in [
"base",
"gpu-base",
"pytorch",
"tensorflow",
"tensorflow2",
"runtime",
],
"unsupported value for --image",
)
log('image "{}": "{}"'.format(parts[0], parts[1]))
Expand Down
Loading