fix: Add testing for explicit model load #8276
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
20 tasks
mattwittwer
changed the title
yinggeh
reviewed
Jul 21, 2025
yinggeh
reviewed
Jul 21, 2025
yinggeh
reviewed
Jul 21, 2025
mattwittwer
force-pushed
the
mwittwer/explicit_model_load_parsing
branch
from
e54cccb to
a32f123
Compare
kthui
approved these changes
Aug 13, 2025
yinggeh
approved these changes
Aug 13, 2025
mattwittwer
added a commit
that referenced
this pull request
Aug 13, 2025
Add tests to confirm python_backend model load parameters are correctly validated
This was referenced Aug 13, 2025
mc-nv
pushed a commit
that referenced
this pull request
Aug 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do?
Add tests to validate the input for model load commands
Checklist
<commit_type>: <Title>Commit Type:
Check the conventional commit type
box here and add the label to the github PR.
Related PRs:
This PR is related to the python backend fix here: triton-inference-server/python_backend#404
Where should the reviewer start?
Review the changes to the python backend first and then confirm the tests are valid.
Test plan:
31707450
Caveats:
Background
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)