Skip to content

ci: Improve error handling for Python backend model initialization failures #8303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Aug 7, 2025
Merged

ci: Improve error handling for Python backend model initialization failures #8303

merged 12 commits into from
Aug 7, 2025

Conversation

pskiran1
Copy link
Member

@pskiran1 pskiran1 commented Jul 21, 2025 •
edited
Loading

What does the PR do?

Checklist

  • PR title reflects the change and is of format <commit_type>: <Title>
  • Changes are described in the pull request.
  • Related issues are referenced.
  • Populated github labels field
  • Added test plan and verified test passes.
  • Verified that the PR passes existing CI.
  • Verified copyright is correct on all changed files.
  • Added succinct git squash message before merging ref.
  • All template sections are filled out.
  • Optional: Additional screenshots for behavior/output changes with before/after.

Commit Type:

Check the conventional commit type
box here and add the label to the github PR.

  • build
  • ci
  • docs
  • feat
  • fix
  • perf
  • refactor
  • revert
  • style
  • test

Related PRs:

Where should the reviewer start?

Test plan:

  • CI Pipeline ID: 32901524, 32938273

Caveats:

Background

triton-inference-server/python_backend#408

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

  • closes GitHub issue: #xxx

@pskiran1 pskiran1 added the PR: ci Changes to our CI configuration files and scripts label Jul 21, 2025
@pskiran1 pskiran1 marked this pull request as ready for review July 21, 2025 14:55
@pskiran1 pskiran1 requested review from krishung5 and yinggeh July 21, 2025 17:06
@yinggeh
Copy link
Contributor

yinggeh commented Jul 23, 2025 •
edited
Loading

Please add related PRs in description triton-inference-server/python_backend#408

@yinggeh yinggeh self-requested a review July 23, 2025 18:26
yinggeh
yinggeh previously approved these changes Jul 23, 2025
View reviewed changes
krishung5
krishung5 reviewed Jul 23, 2025
View reviewed changes
@pskiran1 pskiran1 changed the title ci: Improve error handling for Python backend model initialization failures [Do Not Merge] ci: Improve error handling for Python backend model initialization failures Aug 4, 2025
@pskiran1 pskiran1 changed the title [Do Not Merge] ci: Improve error handling for Python backend model initialization failures ci: Improve error handling for Python backend model initialization failures Aug 5, 2025
@pskiran1 pskiran1 requested a review from kthui August 6, 2025 14:56
krishung5
krishung5 previously approved these changes Aug 6, 2025
View reviewed changes
yinggeh
yinggeh reviewed Aug 6, 2025
View reviewed changes
yinggeh
yinggeh reviewed Aug 7, 2025
View reviewed changes
kthui
kthui previously approved these changes Aug 7, 2025
View reviewed changes
@pskiran1 pskiran1 dismissed stale reviews from kthui and krishung5 via e548869 August 7, 2025 06:26
yinggeh
yinggeh approved these changes Aug 7, 2025
View reviewed changes
Copy link
Contributor

@yinggeh yinggeh left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Make sure CI passes.

@pskiran1 pskiran1 merged commit 5a97991 into main Aug 7, 2025
3 checks passed
@pskiran1 pskiran1 deleted the spolisetty_pb_model_load branch August 7, 2025 10:56
pskiran1 added a commit that referenced this pull request Aug 7, 2025
@pskiran1
ci: Improve error handling for Python backend model initialization fa…
cfac71d 
…ilures (#8303)
@pskiran1 pskiran1 mentioned this pull request Aug 7, 2025
Merged
20 tasks
mc-nv pushed a commit that referenced this pull request Aug 7, 2025
@pskiran1
ci: Improve error handling for Python backend model initialization fa…
993cd15 
…ilures (#8303) (#8333)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yinggeh yinggeh yinggeh approved these changes

@kthui kthui kthui left review comments

@krishung5 krishung5 krishung5 left review comments

Assignees
No one assigned
Labels
PR: ci Changes to our CI configuration files and scripts
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pskiran1 @yinggeh @kthui @krishung5