Skip to content

test: fix sagemaker input size test#8695

Merged
mattwittwer merged 3 commits intomainfrom
mwittwer/fix-sagemaker-input-size-test
Mar 13, 2026
Merged

test: fix sagemaker input size test#8695
mattwittwer merged 3 commits intomainfrom
mwittwer/fix-sagemaker-input-size-test

Conversation

@mattwittwer
Copy link
Contributor

@mattwittwer mattwittwer commented Mar 12, 2026

What does the PR do?

This PR fixes an test error introduced in #8686. The sagemaker input size test fails in the pipeline. This is resolved by switching from the SageMaker sm_model to the identity_fp32 model. Matching the test used in: #8685

Checklist

  • PR title reflects the change and is of format <commit_type>: <Title>
  • Changes are described in the pull request.
  • Related issues are referenced.
  • Populated github labels field
  • Added test plan and verified test passes.
  • Verified that the PR passes existing CI.
  • Verified copyright is correct on all changed files.
  • Added succinct git squash message before merging ref.
  • All template sections are filled out.
  • Optional: Additional screenshots for behavior/output changes with before/after.

Commit Type:

Check the conventional commit type
box here and add the label to the github PR.

  • build
  • ci
  • docs
  • feat
  • fix
  • perf
  • refactor
  • revert
  • style
  • test

Related PRs:

#8686

Where should the reviewer start?

Test plan:

  • CI Pipeline ID:

45931145

Caveats:

Background

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

  • closes GitHub issue: #xxx

@mattwittwer mattwittwer self-assigned this Mar 12, 2026
@mattwittwer mattwittwer requested review from whoisj and yinggeh March 13, 2026 19:14
Copy link
Contributor

@whoisj whoisj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved assuming CI passes.

@mattwittwer mattwittwer merged commit 4c4b3ae into main Mar 13, 2026
3 checks passed
@mattwittwer mattwittwer deleted the mwittwer/fix-sagemaker-input-size-test branch March 13, 2026 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants