Skip to content

Commit 8d8fd2a

Browse files
committed
Update tests based on comments
1 parent 0dadc8e commit 8d8fd2a

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

ci/L0_backend_vllm/metrics_test/test.sh

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ function assert_curl_success {
5050

5151
rm -rf models && mkdir -p models
5252
cp -r ${SAMPLE_MODELS_REPO}/vllm_model models/vllm_opt
53-
# `vllm_opt`` model will be loaded on server start and stay loaded throughout
53+
# `vllm_opt` model will be loaded on server start and stay loaded throughout
5454
# unittesting. To ensure that vllm's memory profiler will not error out
5555
# on `vllm_load_test` load, we reduce "gpu_memory_utilization" for `vllm_opt`,
5656
# so that at least 60% of GPU memory was available for other models.
@@ -71,7 +71,7 @@ python3 $CLIENT_PY VLLMTritonMetricsTest.test_vllm_metrics -v > $CLIENT_LOG 2>&1
7171

7272
if [ $? -ne 0 ]; then
7373
cat $CLIENT_LOG
74-
echo -e "\n***\n*** Running $CLIENT_PY FAILED. \n***"
74+
echo -e "\n***\n*** Running $CLIENT_PY VLLMTritonMetricsTest.test_vllm_metrics FAILED. \n***"
7575
RET=1
7676
else
7777
check_test_results $TEST_RESULT_FILE $EXPECTED_NUM_TESTS
@@ -101,7 +101,7 @@ python3 $CLIENT_PY VLLMTritonMetricsTest.test_vllm_metrics_disabled -v > $CLIENT
101101

102102
if [ $? -ne 0 ]; then
103103
cat $CLIENT_LOG
104-
echo -e "\n***\n*** Running $CLIENT_PY FAILED. \n***"
104+
echo -e "\n***\n*** Running $CLIENT_PY VLLMTritonMetricsTest.test_vllm_metrics_disabled FAILED. \n***"
105105
RET=1
106106
else
107107
check_test_results $TEST_RESULT_FILE $EXPECTED_NUM_TESTS
@@ -132,7 +132,7 @@ python3 $CLIENT_PY VLLMTritonMetricsTest.test_vllm_metrics -v > $CLIENT_LOG 2>&1
132132

133133
if [ $? -ne 0 ]; then
134134
cat $CLIENT_LOG
135-
echo -e "\n***\n*** Running $CLIENT_PY FAILED. \n***"
135+
echo -e "\n***\n*** Running $CLIENT_PY VLLMTritonMetricsTest.test_vllm_metrics FAILED. \n***"
136136
RET=1
137137
else
138138
check_test_results $TEST_RESULT_FILE $EXPECTED_NUM_TESTS

ci/L0_backend_vllm/vllm_backend/test.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ function assert_curl_success {
5050

5151
rm -rf models && mkdir -p models
5252
cp -r ${SAMPLE_MODELS_REPO}/vllm_model models/vllm_opt
53-
# `vllm_opt`` model will be loaded on server start and stay loaded throughout
53+
# `vllm_opt` model will be loaded on server start and stay loaded throughout
5454
# unittesting. To test vllm model load/unload we use a dedicated
5555
# `vllm_load_test`. To ensure that vllm's memory profiler will not error out
5656
# on `vllm_load_test` load, we reduce "gpu_memory_utilization" for `vllm_opt`,

0 commit comments

Comments
 (0)