fix multi-GPU validation to include pipeline parallelism#116
Merged
yinggeh merged 3 commits intotriton-inference-server:mainfrom Jan 9, 2026
Merged
Conversation
Contributor
Author
Contributor
|
Can you also update the copyright to 2026 in the first line? |
Contributor
Author
|
@yinggeh done, ready to merge |
Contributor
|
@nightflight-dk You should only update copyrights of the file you edited, which is |
Contributor
Author
|
yinggeh
approved these changes
Jan 9, 2026
Contributor
|
Thanks for contributing. This change will be included in Triton 26.01 release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the validation logic in TritonPythonModel to correctly identify multi-GPU configurations that use Pipeline Parallelism (PP).
Previously, the check only considered Tensor Parallelism (TP) size (tensor_parallel_size > 1) when verifying if a model configured with KIND_GPU (intended for single-GPU) was attempting to run in a multi-GPU setup. This meant that models using Pipeline Parallelism (where pipeline_parallel_size > 1) could potentially bypass this check if tensor_parallel_size was 1.
Changes:
Retrieve pipeline_parallel_size from vllm_engine_config (defaulting to 1).
Update the validation condition to check if the total parallelism (tp_size * pp_size) exceeds 1.
Ensures that users are correctly prompted to use KIND_MODEL for any multi-GPU configuration, whether it involves TP, PP, or both.
Testing:
Verified that setting pipeline_parallel_size > 1 with
KIND_GPU now raises the expected ValueError.