Skip to content

Setting shutdown asyncio event in a thread-safe manner #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 20, 2024
Merged

Setting shutdown asyncio event in a thread-safe manner #78

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0e6f5ef
replasing asyncio event with threading event
oandreeva-nv Dec 20, 2024
8c30208
Using self._event_loop.call_soon_threadsafe
oandreeva-nv Dec 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ci/L0_backend_vllm/metrics_test/test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,11 +75,11 @@ run_test() {
fi
fi

set -e

# TODO: Non-graceful shutdown when metrics are enabled.
kill $SERVER_PID
wait $SERVER_PID

set -e
}

RET=0
Expand Down
2 changes: 1 addition & 1 deletion src/model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -800,7 +800,7 @@ def _check_health(self, requests):

def finalize(self):
self.logger.log_info("[vllm] Issuing finalize to vllm backend")
self._llm_engine_shutdown_event.set()
self._event_loop.call_soon_threadsafe(self._llm_engine_shutdown_event.set)

# Shutdown the event thread.
if self._event_thread is not None:
Expand Down
Loading