Skip to content

[AMD] Enable reordering across ops with nested regions #5363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 13, 2024
Merged

[AMD] Enable reordering across ops with nested regions #5363

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 2 additions & 10 deletions third_party/amd/lib/TritonAMDGPUTransforms/ReorderInstructions.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,22 +227,17 @@ static void scheduleGlobalLoadLocalStore(triton::FuncOp funcOp) {
// Gather use-def chain in block.
Block *block = op->getBlock();
bool leadsToLoad = false;
bool dontReorder = false;
SetVector<Operation *> backwardSet;

BackwardSliceOptions options;
options.omitBlockArguments = true;
options.inclusive = false;
// Slice should inlcude values flowing into op regions
options.omitUsesFromAbove = false;
options.filter = [&](Operation *defOp) -> bool {
Block *defBlock = defOp->getBlock();
if (!block->findAncestorOpInBlock(*defOp))
return false;
// Don't hoist control flow as we don't track backtraces of ops within
// their regions.
if (isa<scf::IfOp, scf::ForOp, scf::WhileOp>(defOp)) {
dontReorder = true;
return false;
}

// Check for a `load` dependent path.
leadsToLoad |= isa<triton::LoadOp>(defOp);
Expand All @@ -252,9 +247,6 @@ static void scheduleGlobalLoadLocalStore(triton::FuncOp funcOp) {
mlir::getBackwardSlice(op, &backwardSet, options);
backwardSet.insert(op);

// If we found ops in the slice we don't want to hoist.
if (dontReorder)
continue;
// Don't move a local_store if its source is a load from
// the same iteration.
if (isa<ttg::LocalStoreOp>(op) && leadsToLoad)
Expand Down
Loading