Skip to content

Conversation

@AndreyPavlenko
Copy link

The isF...() methods have been removed in the main LLVM branch: llvm/llvm-project#123326

New contributor declaration

  • I am not making a trivial change, such as fixing a typo in a comment.

  • I have written a PR description following these
    rules.

  • I have run pre-commit run --from-ref origin/main --to-ref HEAD.

  • Select one of the following.

    • I have added tests.
      • /test for lit tests
      • /unittest for C++ tests
      • /python/test for end-to-end tests
    • This PR does not need a test because it fixes build failures.
  • Select one of the following.

    • I have not added any lit tests.
    • The lit tests I have added follow these best practices,
      including the "tests should be minimal" section. (Usually running Python code
      and using the instructions it generates is not minimal.)

The isF...() methods have been removed in the main LLVM branch:
llvm/llvm-project#123326
@Jokeren
Copy link
Contributor

Jokeren commented Jan 27, 2025

@peterbell10 I'm not sure why there are several PRs that handling similar stuff. IIUC, we should focus on the other one instead? #5684

@AndreyPavlenko
Copy link
Author

@peterbell10 I'm not sure why there are several PRs that handling similar stuff. IIUC, we should focus on the other one instead? #5684

Sorry, I wasn't aware of that one.

@peterbell10
Copy link
Contributor

Agreed, closing as duplicate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants