[NFC] replace TritonGPUToLLVM/Utility.h macros with TritonLLVMOpBuilder #5717
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makslevental
force-pushed
the
makslevental/remove-macros
branch
3 times, most recently
from
3c90853 to
857dea8
Compare
makslevental
changed the title
makslevental
force-pushed
the
makslevental/remove-macros
branch
from
857dea8 to
98efa53
Compare
makslevental
requested review from
antiagainst,
ptillet and
zhanglx13
as code owners
Contributor
Author
|
@peterbell10 please take a look when you get a chance. |
peterbell10
reviewed
Jan 27, 2025
Contributor
peterbell10
left a comment
peterbell10
left a comment
There was a problem hiding this comment.
Some nits but otherwise LGTM
peterbell10
approved these changes
Jan 28, 2025
Contributor
peterbell10
left a comment
peterbell10
left a comment
There was a problem hiding this comment.
Looks good, will wait a bit to merge in case anyone else has thoughts though.
Collaborator
|
What llvm change causes the macor to not work anymore? |
Contributor
Author
I didn't bisect to find which commit but the issue is a collision with these members https://github.com/llvm/llvm-project/blob/1a5d8926c5f9c1e75a285e122cf6cad0191a41b5/llvm/include/llvm/IR/ConstantRange.h#L403 |
makslevental
force-pushed
the
makslevental/remove-macros
branch
from
69cd4af to
57f742b
Compare
antiagainst
approved these changes
Jan 28, 2025
Collaborator
|
Thanks for taking care of this @makslevental! |
Contributor
Author
Discussed with @ThomasRaoux - gonna hold for a bit before landing |
makslevental
force-pushed
the
makslevental/remove-macros
branch
from
57f742b to
d0dafa5
Compare
AlexAUT
pushed a commit
to AlexAUT/triton
that referenced
this pull request
Jan 29, 2025
makslevental
added a commit
to makslevental/triton
that referenced
this pull request
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5691 and unblocks #5684