Skip to content

Conversation

@Jokeren
Copy link
Contributor

@Jokeren Jokeren commented Apr 10, 2025

No description provided.

@Jokeren Jokeren marked this pull request as ready for review April 15, 2025 13:39
@Jokeren Jokeren requested a review from ptillet as a code owner April 15, 2025 13:39
"HIP": {
"gfx90a": lambda width, **kwargs: 383e12 / (width / 8),
"gfx941": lambda width, **kwargs: 2614.9e12 / (width / 8),
"gfx942": lambda width, **kwargs: 2614.9e12 / (width / 8),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@antiagainst shall we drop a 0 or None value here for gfx950?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. The spec is unavailable right now. For mi300x and mi325x you can see the spec in https://github.com/triton-lang/triton/pull/6513/files#diff-5e6a8d3fc5ad9de85fc09ead926355cc19497d3056c368d463bf4c626ce68540. Can drop gfx941 here given that's deprecated.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So only "gfx90a" and "gfx942" at this moment?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also cc @ptillet for any additional comments

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup--gfx90a for mi210/mi250, gfx942 for mi300/mi325. gfx940 and gfx941 was deprecated, see llvm/llvm-project#126763.

@Jokeren Jokeren force-pushed the keren/bench-refactor branch from d0893dd to f55c57f Compare April 19, 2025 21:03
@Jokeren
Copy link
Contributor Author

Jokeren commented Apr 30, 2025

@ptillet Any other concerns with the changes?

@Jokeren Jokeren force-pushed the keren/bench-refactor branch from 338cf51 to 8a73a20 Compare May 24, 2025 19:00
@ptillet ptillet merged commit cd62a76 into main May 27, 2025
8 checks passed
@ptillet ptillet deleted the keren/bench-refactor branch May 27, 2025 23:29
name = "triton_kernels"
version = "1.0.0"
dependencies = ["torch", "numpy", "pytest"]
dependencies = ["torch", "numpy", "pytest", "llnl-hatchet"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This dependency is causing problems internally because it depends on numpy 1. It appears that hatchet is not actually used inside triton_kernels here, so I think it should be possible to remove this dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants