[triton_kernels][swiglu] Add standard implementation of swiglu #8460
+56
−18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of
swiglucomputes a variant of the standard SwiGLU activation by adding a bias term (i.e., returningout_gelu * (a_linear + 1)instead ofout_gelu * a_linear), and optionally applies input clipping and sigmoid input scaling.This PR makes the bias addition optional (defaulting to
Truefor backward compatibility) and introducesstandard_swiglu, which computes the standard SwiGLU activation without bias addition, input clipping, or sigmoid input scaling.