Compile-time logging improvement #8506
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This augments the
optimize_moduledefinition to also toLLVM_ENABLE_TIMING=1, bringing it to parity withtranslate_to_asm. Note thatoptimize_moduleuses the new pass manager, whiletranslate_to_asmuses the legacy pass manager. This, plus effort to maintain reasonable inter-operability with the existingLLVM_IR_ENABLE_DUMPbehavior, lead to more complicated control flow than expected.New contributor declaration
I am not making a trivial change, such as fixing a typo in a comment.
I have written a PR description following these
rules.
I have run
pre-commit run --from-ref origin/main --to-ref HEAD. Yes, I did this, and everything is "Skipped" or "Passed".Select one of the following.
[ ] I have added tests.this is augmenting debugging information, and searching for the environment variables involved it's not under test.Select one of the following.
littests.[ ] Thelittests I have added follow these best practices,including the "tests should be minimal" section. (Usually running Python code
and using the instructions it generates is not minimal.)