[Backend] Bump to llvm/llvm-project@ebf5d9e #8840
Open
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raikonenfnu
requested review from
CRobeck,
Jokeren,
antiagainst,
fywkevin,
lezcano,
peterbell10 and
zhanglx13
as code owners
raikonenfnu
force-pushed
the
llvm-bump-ebf5d9e
branch
from
9666997 to
677efd2
Compare
This bump picks up llvm/llvm-project#169546 which resolves some register spilling in downstream use cases. Additionally, we also pick up llvm/llvm-project#166648 which converted udiv and sdiv to non Pure attributes. This require changes on warp_specialize_to_llvm.mlir `remat_subgraph` since the original test found in triton-lang@8601b39 was meant to test rematerializing some "pure ops" into partition region, which the tested udiv is no longer. This PR Replaced it with urem which is similar class of op who still has Pure trait. Signed-off-by: Stanley Winata <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bump picks up llvm/llvm-project#169546 which resolves some register spilling in downstream use cases.
Additionally, we also pick up llvm/llvm-project#166648 which converted udiv and sdiv to non Pure attributes. This require changes on warp_specialize_to_llvm.mlir
remat_subgraphsince the original test found in 8601b39 was meant to test rematerializing some "pure ops" into partition region, which the tested udiv is no longer. Replaced it with urem which is similar class of op who still has Pure trait.