[AMD] Add check for cooperative groups support in driver #8935
+10
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: nithinsubbiah <[email protected]>
antiagainst
requested changes
Dec 8, 2025
Collaborator
antiagainst
left a comment
antiagainst
left a comment
There was a problem hiding this comment.
Hmm, I'm not sure this is proper--cooperative launch should not depend on num ctas > 1.
Signed-off-by: nithinsubbiah <[email protected]>
nithinsubbiah
changed the title
Signed-off-by: nithinsubbiah <[email protected]>
antiagainst
requested changes
Dec 11, 2025
| assert isinstance(driver, HIPDriver) | ||
| device = driver.get_current_device() | ||
| device_properties = driver.utils.get_device_properties(device) | ||
| self.launch_cooperative_grid = device_properties['cooperativeLaunch'] |
Collaborator
There was a problem hiding this comment.
We should assert the device supports cooperative launch here instead of silently overwriting what the developer said. Rationale being that the developer indicates they want cooperative launch. That's likely due to some forward progress needs which demands certain number of blocks to co-launch. By silently overwriting that it can be a big suprise for developers to see hangs or incorrect results. In general, if reality doesn't match with what the developer explicitly said, better to be noisy and error out than "correct" it under the hood for developer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a check for cooperative groups support in the driver.