[FPSAN] Support for extern_elementwise in fpsan#9645
[FPSAN] Support for extern_elementwise in fpsan#9645pawelszczerbuk wants to merge 4 commits intotriton-lang:mainfrom
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9803be01c8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 41fd0cb93e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (!op.getPure() || !isFloatLike(op.getType()) || | ||
| op.getNumOperands() == 0 || !externHasNumericOperands(op)) | ||
| return failure(); |
There was a problem hiding this comment.
Drop the isFloatLike(op.getType()) gate here. It prevents rewriting libdevice-style float→int externs (e.g., float2int_*, ilogb, isnan), and the later unsupported-extern walk then fails the pass for them. That breaks the commit intent to support arbitrary float extern_elementwise (including libdevice functions) and causes valid kernels to fail under fpsan.
Useful? React with 👍 / 👎.
1 participant
Tighten fpsan to support arbitrary float extern_elementwise, including all the libdevice functions.