[PROTON] Remove incorrect conversions between nanoseconds and cycles.#9660
Open
ray-kast wants to merge 1 commit intotriton-lang:mainfrom
Open
[PROTON] Remove incorrect conversions between nanoseconds and cycles.#9660ray-kast wants to merge 1 commit intotriton-lang:mainfrom
ray-kast wants to merge 1 commit intotriton-lang:mainfrom
Conversation
fywkevin
requested changes
Mar 6, 2026
Contributor
fywkevin
left a comment
There was a problem hiding this comment.
Using global_time has much lower timing resolution than cycle (see the Q&A here: https://forums.developer.nvidia.com/t/questions-about-globaltimer-functionality-accessing-and-configuring/304268), and it sometimes has uncertain large inaccuracy. Here we are targeting cycle-level events so need a high-resolution clock32/clock64.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The addition of
TargetInfoBase::globalTimeupdatesTraceWriterto convert recorded cycle counts to globally-consistent nanosecond timestamps. However, the conversion is done using the hard-coded assumption of a 1GHz clock, which results in events being stretched or squashed to incorrect durations should that assumption not hold. Short of performing complex clock synchronization logic, removing calls toTargetInfoBase::clockand replacing them withTargetInfoBase::globalTimeto nullify the need for this math is the cleanest fix for it.New contributor declaration
I am not making a trivial change, such as fixing a typo in a comment.
I have written a PR description following these
rules.
I have run
pre-commit run --from-ref origin/main --to-ref HEAD.Select one of the following.
/testforlittests/unittestfor C++ tests/python/testfor end-to-end testsglobalTimeis not deterministic.Select one of the following.
littests.littests I have added follow these best practices,including the "tests should be minimal" section. (Usually running Python code
and using the instructions it generates is not minimal.)