Compact Vector of Vectors #120
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move check_cell_bounds() and construct_backends() to separate cell_lists_util.jl to share functionality between different cell lists.
- Move functions from cell_lists_util.jl to cell_lists.jl - Change dispatch in `supported_update_strategies()` - Change doc string of SHCL (SpatialHashingCellList)
- Add `@inbounds` in `push_cell_atomic!` - Improved type dispatch for `supported_update_strategies` - Clarified and cleaned up cell list initialization and emptying, - General code cleanup.
Add basic test for SVOV WIP to adapt FullGridCellList and GridNHS to use SVOV
Add basic unit test and CVOV to `test/neighborhood_search.jl` (tests are succeeding) Add update_grid!() and initialize_grid!()
…n in n_particles_per_cell.
|
@efaulhaber Please review. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #120 +/- ##
==========================================
+ Coverage 86.94% 87.44% +0.49%
==========================================
Files 15 16 +1
Lines 659 717 +58
==========================================
+ Hits 573 627 +54
- Misses 86 90 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #111.
Add data structure with contiguous memory layout, similar to DynamicVectorOfVectors. As opposed to DynamicVectorOfVectors, this data structure does not support modifying operations like
push!.