Convert pos_diff to NHS eltype if coordinates have a different eltype
#132
+12
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #132 +/- ##
==========================================
+ Coverage 86.94% 86.96% +0.01%
==========================================
Files 15 15
Lines 659 660 +1
==========================================
+ Hits 573 574 +1
Misses 86 86
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…ixiNeighborhoodSearch.jl into ef/coordinates-eltype
There was a problem hiding this comment.
Pull Request Overview
This PR adds type conversion for position differences to ensure consistent numerical precision throughout neighborhood search operations, and optimizes the precomputed neighborhood search with @inbounds annotation.
- Adds a new
eltypemethod forAbstractNeighborhoodSearchto retrieve the element type from the search radius - Converts
pos_diffto match the neighborhood search's element type at three key locations - Adds
@inboundsannotation to theextract_svectorcall inPrecomputedNeighborhoodSearchfor a ~20% GPU speedup
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/neighborhood_search.jl | Defines eltype method for AbstractNeighborhoodSearch and applies type conversion to pos_diff in generic foreach_neighbor |
| src/nhs_grid.jl | Applies type conversion to pos_diff in GridNeighborhoodSearch's specialized foreach_neighbor |
| src/nhs_precomputed.jl | Applies type conversion to pos_diff and adds @inbounds annotation with updated safety comment in PrecomputedNeighborhoodSearch's foreach_neighbor |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
LasNikas
approved these changes
Nov 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.