Skip to content

Conversation

@efaulhaber
Copy link
Member

With these remaining two @inbounds, the resulting device code does not contain any exceptions.
However, the WCSPH benchmark is only 2% faster on an Nvidia H100, and these two @inbounds are not safe, so there is no reason to do this.
This PR is just a reference to evaluate the impact of the remaining exceptions and is not meant to be merged.

@codecov
Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.21%. Comparing base (4f938d3) to head (1ce0022).
Report is 3 commits behind head on ef/inbounds2.

Additional details and impacted files
@@              Coverage Diff              @@
##           ef/inbounds2      #79   +/-   ##
=============================================
  Coverage         88.21%   88.21%           
=============================================
  Files                15       15           
  Lines               492      492           
=============================================
  Hits                434      434           
  Misses               58       58           
Flag Coverage Δ
unit 88.21% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@efaulhaber efaulhaber self-assigned this Nov 14, 2024
Base automatically changed from ef/inbounds2 to main November 18, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants