Add entropy2cons for CompressibleEulerQuasi1D#2385
Add entropy2cons for CompressibleEulerQuasi1D#2385jlchan merged 10 commits intotrixi-framework:mainfrom
entropy2cons for CompressibleEulerQuasi1D#2385Conversation
Review checklistThis checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging. Purpose and scope
Code quality
Documentation
Testing
Performance
Verification
Created with ❤️ by the Trixi.jl community. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2385 +/- ##
==========================================
+ Coverage 96.94% 96.95% +0.01%
==========================================
Files 504 504
Lines 41717 41721 +4
==========================================
+ Hits 40440 40448 +8
+ Misses 1277 1273 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
patrickersing
left a comment
There was a problem hiding this comment.
Thanks for adding this!
This looks almost ready to merge, I would just add an additional unit test for the conversion between conservative and entropy variables.
Co-authored-by: Patrick Ersing <114223904+patrickersing@users.noreply.github.com>
This enables modal flux differencing
DGMultisolvers, and adds a new test.This should also retain coverage which decreases after moving SWE to TrixiSWE.jl in #2379.