Skip to content

Conversation

@vchuravy
Copy link
Member

This is a rebase of #2417

The gist is that we allow the user to choose a ":serial" backend and we merge the CPU backend switch for KernelAbstraction support

@vchuravy vchuravy added parallelization Related to MPI, threading, tasks etc. breaking labels Jul 18, 2025
@vchuravy vchuravy requested review from benegee and ranocha July 18, 2025 08:41
@github-actions
Copy link
Contributor

Review checklist

This checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging.

Purpose and scope

  • The PR has a single goal that is clear from the PR title and/or description.
  • All code changes represent a single set of modifications that logically belong together.
  • No more than 500 lines of code are changed or there is no obvious way to split the PR into multiple PRs.

Code quality

  • The code can be understood easily.
  • Newly introduced names for variables etc. are self-descriptive and consistent with existing naming conventions.
  • There are no redundancies that can be removed by simple modularization/refactoring.
  • There are no leftover debug statements or commented code sections.
  • The code adheres to our conventions and style guide, and to the Julia guidelines.

Documentation

  • New functions and types are documented with a docstring or top-level comment.
  • Relevant publications are referenced in docstrings (see example for formatting).
  • Inline comments are used to document longer or unusual code sections.
  • Comments describe intent ("why?") and not just functionality ("what?").
  • If the PR introduces a significant change or new feature, it is documented in NEWS.md with its PR number.

Testing

  • The PR passes all tests.
  • New or modified lines of code are covered by tests.
  • New or modified tests run in less then 10 seconds.

Performance

  • There are no type instabilities or memory allocations in performance-critical parts.
  • If the PR intent is to improve performance, before/after time measurements are posted in the PR.

Verification

  • The correctness of the code was verified using appropriate tests.
  • If new equations/methods are added, a convergence test has been run and the results
    are posted in the PR.

Created with ❤️ by the Trixi.jl community.

@codecov
Copy link

codecov bot commented Jul 18, 2025

Codecov Report

Attention: Patch coverage is 45.45455% with 6 lines in your changes missing coverage. Please review.

Project coverage is 89.15%. Comparing base (2bc1208) to head (4a11b04).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/auxiliary/math.jl 0.00% 6 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (2bc1208) and HEAD (4a11b04). Click for more details.

HEAD has 5 uploads less than BASE
Flag BASE (2bc1208) HEAD (4a11b04)
unittests 26 21
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2476      +/-   ##
==========================================
- Coverage   96.67%   89.15%   -7.52%     
==========================================
  Files         507      507              
  Lines       42010    42005       -5     
==========================================
- Hits        40610    37446    -3164     
- Misses       1400     4559    +3159     
Flag Coverage Δ
unittests 89.15% <45.45%> (-7.52%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@ranocha ranocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Could you please

?

@vchuravy vchuravy requested a review from ranocha July 18, 2025 13:14
@vchuravy
Copy link
Member Author

Done!

@vchuravy vchuravy enabled auto-merge (squash) July 18, 2025 13:15
ranocha
ranocha previously approved these changes Jul 18, 2025
Copy link
Member

@ranocha ranocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ranocha ranocha mentioned this pull request Jul 10, 2025
9 tasks
benegee
benegee previously approved these changes Jul 18, 2025
@vchuravy vchuravy dismissed stale reviews from benegee and ranocha via 4a11b04 July 18, 2025 19:53
Copy link
Member

@ranocha ranocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ranocha ranocha disabled auto-merge July 21, 2025 08:40
@ranocha ranocha merged commit c3cee00 into main Jul 21, 2025
33 of 39 checks passed
@ranocha ranocha deleted the vc-afilogo/backends branch July 21, 2025 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking parallelization Related to MPI, threading, tasks etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants