-
Notifications
You must be signed in to change notification settings - Fork 132
Support serial execution and introduce backend preference #2476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Valentin Churavy <[email protected]>
Review checklistThis checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging. Purpose and scope
Code quality
Documentation
Testing
Performance
Verification
Created with ❤️ by the Trixi.jl community. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2476 +/- ##
==========================================
- Coverage 96.67% 89.15% -7.52%
==========================================
Files 507 507
Lines 42010 42005 -5
==========================================
- Hits 40610 37446 -3164
- Misses 1400 4559 +3159
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ranocha
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Could you please
- bump the version in to v0.13.0-DEV
Line 4 in dbf254b
version = "0.12.8-DEV" - add a NEWS.md entry
?
Co-authored-by: Hendrik Ranocha <[email protected]>
|
Done! |
ranocha
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
ranocha
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This is a rebase of #2417
The gist is that we allow the user to choose a ":serial" backend and we merge the CPU backend switch for KernelAbstraction support