Skip to content

Remove AMDGPU extension #2485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 21, 2025
Merged

Remove AMDGPU extension #2485

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b059ad8
Remove AMDGPU extension
vchuravy Jul 21, 2025
2298a53
Merge branch 'main' into vc/nix_amd
ranocha Jul 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,22 +54,19 @@ TrixiBase = "9a0f1c46-06d5-4909-a5a3-ce25d3fa3284"
UUIDs = "cf7118a7-6976-5b1a-9a39-7adc72f591a4"

[weakdeps]
AMDGPU = "21141c5a-9bdb-4563-92ae-f87d6854732e"
CUDA = "052768ef-5323-5732-b1bb-66c8b64840ba"
Convex = "f65535da-76fb-5f13-bab9-19810c17039a"
ECOS = "e2685f51-7e38-5353-a97d-a921fd2c8199"
Makie = "ee78f7c6-11fb-53f2-987a-cfe4a2b5a57a"
NLsolve = "2774e3e8-f4cf-5e23-947b-6d7e65073b56"

[extensions]
TrixiAMDGPUExt = "AMDGPU"
TrixiCUDAExt = "CUDA"
TrixiConvexECOSExt = ["Convex", "ECOS"]
TrixiMakieExt = "Makie"
TrixiNLsolveExt = "NLsolve"

[compat]
AMDGPU = "1.3.5"
Accessors = "0.1.36"
Adapt = "4"
CUDA = "5.8"
Expand Down
19 changes: 0 additions & 19 deletions ext/TrixiAMDGPUExt.jl
View file
Open in desktop

This file was deleted.

2 changes: 0 additions & 2 deletions test/Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
[deps]
ADTypes = "47edcb42-4c32-4615-8424-f2b9edc5f35b"
AMDGPU = "21141c5a-9bdb-4563-92ae-f87d6854732e"
Adapt = "79e6a3ab-5dfb-504d-930d-738a2a938a0e"
Aqua = "4c88cf16-eb10-579e-8560-4a9242c79595"
CairoMakie = "13f3f980-e62b-5c42-98c6-ff1f3baf88f0"
Expand Down Expand Up @@ -34,7 +33,6 @@ TrixiTest = "0a316866-cbd0-4425-8bcb-08103b2c1f26"
[compat]
Adapt = "4"
ADTypes = "1.11"
AMDGPU = "1.3.5"
Aqua = "0.8"
CairoMakie = "0.12, 0.13, 0.14, 0.15"
Convex = "0.16"
Expand Down
9 changes: 0 additions & 9 deletions test/runtests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,13 +118,4 @@ const TRIXI_NTHREADS = clamp(Sys.CPU_THREADS, 2, 3)
@warn "Unable to run CUDA tests on this machine"
end
end

@time if TRIXI_TEST == "all" || TRIXI_TEST == "AMDGPU"
import AMDGPU
if AMDGPU.functional()
include("test_amdgpu.jl")
else
@warn "Unable to run AMDGPU tests on this machine"
end
end
end
79 changes: 0 additions & 79 deletions test/test_amdgpu.jl
View file
Open in desktop

This file was deleted.

Loading