-
Notifications
You must be signed in to change notification settings - Fork 131
Revert "Add Elixir for Measurements.jl" #2525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This reverts commit 13fd168.
Review checklistThis checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging. Purpose and scope
Code quality
Documentation
Testing
Performance
Verification
Created with ❤️ by the Trixi.jl community. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2525 +/- ##
==========================================
+ Coverage 95.18% 96.76% +1.58%
==========================================
Files 512 512
Lines 42388 42391 +3
==========================================
+ Hits 40345 41016 +671
+ Misses 2043 1375 -668
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In that case: Maybe also revert the example presented in the docs?
I just added the elixir to more or less test the docs - which turned out to be simultaneously a good and bad idea :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's see how our CI system responds to this change first. Removing the example in the docs or fixing the underlying issue can be done later.
Reverts #2504 should remove the stochastic failure from CI until we have enough time to debug the cause (see #2524)