Comments NSF (Entropy-Var) Gradients

src/equations/compressible_navier_stokes_1d.jl

@@ -124,8 +124,8 @@ end
 
 # TODO: parabolic
 # This is the flexibility a user should have to select the different gradient variable types
-# varnames(::typeof(cons2prim)   , ::CompressibleNavierStokesDiffusion1D) = ("v1", "T")
-# varnames(::typeof(cons2entropy), ::CompressibleNavierStokesDiffusion1D) = ("w2", "w3")
+# varnames(::typeof(cons2prim)   , ::CompressibleNavierStokesDiffusion1D) = ("rho", "v1", "T")
+# varnames(::typeof(cons2entropy), ::CompressibleNavierStokesDiffusion1D) = ("w1", "w2", "w3")
 
 function varnames(variable_mapping,
                   equations_parabolic::CompressibleNavierStokesDiffusion1D)
@@ -215,10 +215,10 @@ end
     return cons2prim(entropy2cons(u_transformed, equations), equations)
 end
 
-# Takes the solution values `u` and gradient of the entropy variables (w_2, w_3) and
-# reverse engineers the gradients to be terms of the primitive variables (v1, T).
+# Takes the solution values `u` and gradient of the entropy variables w and
+# reverse engineers the gradients to be terms of the primitive variables u_prim = (rho, v1, v2, T).
 # Helpful because then the diffusive fluxes have the same form as on paper.
-# Note, the first component of `gradient_entropy_vars` contains gradient(rho) which is unused.
+# Note, the first component of `gradient_entropy_vars` w1 contains gradient(rho) which is unused.
 # TODO: parabolic; entropy stable viscous terms
 @inline function convert_derivative_to_primitive(u, gradient,
                                                  ::CompressibleNavierStokesDiffusion1D{GradientVariablesPrimitive})

src/equations/compressible_navier_stokes_2d.jl

@@ -124,8 +124,8 @@ end
 
 # TODO: parabolic
 # This is the flexibility a user should have to select the different gradient variable types
-# varnames(::typeof(cons2prim)   , ::CompressibleNavierStokesDiffusion2D) = ("v1", "v2", "T")
-# varnames(::typeof(cons2entropy), ::CompressibleNavierStokesDiffusion2D) = ("w2", "w3", "w4")
+# varnames(::typeof(cons2prim)   , ::CompressibleNavierStokesDiffusion2D) = ("rho", "v1", "v2", "T")
+# varnames(::typeof(cons2entropy), ::CompressibleNavierStokesDiffusion2D) = ("w1", "w2", "w3", "w4")
 
 function varnames(variable_mapping,
                   equations_parabolic::CompressibleNavierStokesDiffusion2D)
@@ -237,10 +237,10 @@ end
     return cons2prim(entropy2cons(u_transformed, equations), equations)
 end
 
-# Takes the solution values `u` and gradient of the entropy variables (w_2, w_3, w_4) and
-# reverse engineers the gradients to be terms of the primitive variables (v1, v2, T).
+# Takes the solution values `u` and gradient of the entropy variables w and
+# reverse engineers the gradients to be terms of the primitive variables u_prim = (rho, v1, v2, T).
 # Helpful because then the diffusive fluxes have the same form as on paper.
-# Note, the first component of `gradient_entropy_vars` contains gradient(rho) which is unused.
+# Note, the first component of `gradient_entropy_vars` w1 contains gradient(rho) which is unused.
 # TODO: parabolic; entropy stable viscous terms
 @inline function convert_derivative_to_primitive(u, gradient,
                                                  ::CompressibleNavierStokesDiffusion2D{GradientVariablesPrimitive})

src/equations/compressible_navier_stokes_3d.jl

@@ -124,8 +124,8 @@ end
 
 # TODO: parabolic
 # This is the flexibility a user should have to select the different gradient variable types
-# varnames(::typeof(cons2prim)   , ::CompressibleNavierStokesDiffusion3D) = ("v1", "v2", "v3", "T")
-# varnames(::typeof(cons2entropy), ::CompressibleNavierStokesDiffusion3D) = ("w2", "w3", "w4", "w5")
+# varnames(::typeof(cons2prim)   , ::CompressibleNavierStokesDiffusion3D) = ("rho", "v1", "v2", "v3", "T")
+# varnames(::typeof(cons2entropy), ::CompressibleNavierStokesDiffusion3D) = ("w1", "w2", "w3", "w4", "w5")
 
 function varnames(variable_mapping,
                   equations_parabolic::CompressibleNavierStokesDiffusion3D)
@@ -263,10 +263,10 @@ end
     return cons2prim(entropy2cons(u_transformed, equations), equations)
 end
 
-# Takes the solution values `u` and gradient of the entropy variables (w_2, w_3, w_4, w_5) and
-# reverse engineers the gradients to be terms of the primitive variables (v1, v2, v3, T).
+# Takes the solution values `u` and gradient of the entropy variables w and
+# reverse engineers the gradients to be terms of the primitive variables u_prim = (rho, v1, v2, v3, T).
 # Helpful because then the diffusive fluxes have the same form as on paper.
-# Note, the first component of `gradient_entropy_vars` contains gradient(rho) which is unused.
+# Note, the first component of `gradient_entropy_vars` w1 contains gradient(rho) which is unused.
 # TODO: parabolic; entropy stable viscous terms
 @inline function convert_derivative_to_primitive(u, gradient,
                                                  ::CompressibleNavierStokesDiffusion3D{GradientVariablesPrimitive})