Schulz-Rinne (2D) Riemann Problem

[DanielDoehring]

Thanks to @Arpit-Babbar (#2560) . Takes also ideas from #2433

[github-actions]

Review checklist

This checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging.

Purpose and scope

• The PR has a single goal that is clear from the PR title and/or description.
• All code changes represent a single set of modifications that logically belong together.
• No more than 500 lines of code are changed or there is no obvious way to split the PR into multiple PRs.

Code quality

• The code can be understood easily.
• Newly introduced names for variables etc. are self-descriptive and consistent with existing naming conventions.
• There are no redundancies that can be removed by simple modularization/refactoring.
• There are no leftover debug statements or commented code sections.
• The code adheres to our conventions and style guide, and to the Julia guidelines.

Documentation

• New functions and types are documented with a docstring or top-level comment.
• Relevant publications are referenced in docstrings (see example for formatting).
• Inline comments are used to document longer or unusual code sections.
• Comments describe intent ("why?") and not just functionality ("what?").
• If the PR introduces a significant change or new feature, it is documented in NEWS.md with its PR number.

Testing

• The PR passes all tests.
• New or modified lines of code are covered by tests.
• New or modified tests run in less then 10 seconds.

Performance

• There are no type instabilities or memory allocations in performance-critical parts.
• If the PR intent is to improve performance, before/after time measurements are posted in the PR.

Verification

• The correctness of the code was verified using appropriate tests.
• If new equations/methods are added, a convergence test has been run and the results
  are posted in the PR.

Created with ❤️ by the Trixi.jl community.

[codecov]

Codecov Report

❌ Patch coverage is 97.05882% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 96.76%. Comparing base (52bc291) to head (fa02b33).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
...dgsem/elixir_euler_riemannproblem_quadrants_amr.jl	97.06%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2561   +/-   ##
=======================================
  Coverage   96.76%   96.76%           
=======================================
  Files         519      520    +1     
  Lines       42414    42448   +34     
=======================================
+ Hits        41041    41074   +33     
- Misses       1373     1374    +1     

Flag	Coverage Δ
unittests	96.76% <97.06%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Arpit-Babbar]

I just saw that the code coverage error is actually genuine. It seems like this multiple dispatch isn't working. I think it is fine to undo it. Sorry for the wrong suggestion.

The coverage error seems genuine.

[DanielDoehring]

I just saw that the code coverage error is actually genuine. It seems like this multiple dispatch isn't working. I think it is fine to undo it. Sorry for the wrong suggestion.

I do not think this is the issue - the issue is the changed signature:

https://github.com/trixi-framework/Trixi.jl/pull/2212/files#diff-2c7d36606eb2ae74d8571195c5adc60bbdbd969e6fea398fc7ebaaf24d64a203

[DanielDoehring]

I adapted the signature accordingly, should work now