Skip to content

3D support for subcell limiting #2572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 29 commits into
base: main
Choose a base branch
from
Draft

3D support for subcell limiting #2572

wants to merge 29 commits into from

Conversation

@bennibolm
Copy link
Contributor

@bennibolm bennibolm commented Sep 17, 2025 •
edited
Loading

Add 3d support for subcell limiting on P4estMesh

@bennibolm bennibolm added the enhancement New feature or request label Sep 17, 2025
@github-actions
Copy link
Contributor

Review checklist

This checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging.

Purpose and scope

  • The PR has a single goal that is clear from the PR title and/or description.
  • All code changes represent a single set of modifications that logically belong together.
  • No more than 500 lines of code are changed or there is no obvious way to split the PR into multiple PRs.

Code quality

  • The code can be understood easily.
  • Newly introduced names for variables etc. are self-descriptive and consistent with existing naming conventions.
  • There are no redundancies that can be removed by simple modularization/refactoring.
  • There are no leftover debug statements or commented code sections.
  • The code adheres to our conventions and style guide, and to the Julia guidelines.

Documentation

  • New functions and types are documented with a docstring or top-level comment.
  • Relevant publications are referenced in docstrings (see example for formatting).
  • Inline comments are used to document longer or unusual code sections.
  • Comments describe intent ("why?") and not just functionality ("what?").
  • If the PR introduces a significant change or new feature, it is documented in NEWS.md with its PR number.

Testing

  • The PR passes all tests.
  • New or modified lines of code are covered by tests.
  • New or modified tests run in less then 10 seconds.

Performance

  • There are no type instabilities or memory allocations in performance-critical parts.
  • If the PR intent is to improve performance, before/after time measurements are posted in the PR.

Verification

  • The correctness of the code was verified using appropriate tests.
  • If new equations/methods are added, a convergence test has been run and the results
    are posted in the PR.

Created with ❤️ by the Trixi.jl community.

@codecov
Copy link

codecov bot commented Sep 17, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 74.78778% with 297 lines in your changes missing coverage. Please review.
✅ Project coverage is 96.22%. Comparing base (1d75f8f) to head (50a361f).

Files with missing lines Patch % Lines
src/solvers/dgsem_p4est/dg_3d_subcell_limiters.jl 57.71% 225 Missing ⚠️
src/equations/ideal_glm_mhd_3d.jl 42.42% 57 Missing ⚠️
src/solvers/dgsem_p4est/subcell_limiters_3d.jl 97.27% 9 Missing ⚠️
src/callbacks_stage/subcell_bounds_check_3d.jl 93.65% 4 Missing ⚠️
...llbacks_stage/subcell_limiter_idp_correction_3d.jl 97.30% 1 Missing ⚠️
src/solvers/dgsem_tree/containers_3d.jl 98.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2572      +/-   ##
==========================================
- Coverage   96.81%   96.22%   -0.59%     
==========================================
  Files         535      541       +6     
  Lines       42813    43990    +1177     
==========================================
+ Hits        41446    42327     +881     
- Misses       1367     1663     +296
Flag Coverage Δ
unittests 96.22% <74.79%> (-0.59%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bennibolm bennibolm mentioned this pull request Sep 18, 2025
Merged
@bennibolm bennibolm requested review from DanielDoehring and removed request for DanielDoehring September 18, 2025 11:45
@amrueda amrueda mentioned this pull request Sep 18, 2025
Draft
@DanielDoehring
Copy link
Member

This is huge - could we maybe do euler only first to get a feeling for this?

@bennibolm
Copy link
Contributor Author

This is huge - could we maybe do euler only first to get a feeling for this?

Yes, the plan is not to merge everything at once. First, Euler and probably only one limiting option.

amrueda
amrueda reviewed Sep 22, 2025
View reviewed changes
JoshuaLampert
JoshuaLampert requested changes Sep 23, 2025
View reviewed changes
bennibolm
bennibolm commented Sep 24, 2025
View reviewed changes
bennibolm
bennibolm commented Sep 24, 2025
View reviewed changes
src/equations/ideal_glm_mhd_3d.jl
Comment on lines 1446 to 1458
# Transformation from conservative variables u to d(p)/d(u)
@inline function gradient_conservative(::typeof(pressure),
u,
equations::IdealGlmMhdEquations3D)
rho, rho_v1, rho_v2, rho_v3, rho_e, B1, B2, B3, psi = u

v1 = rho_v1 / rho
v2 = rho_v2 / rho
v3 = rho_v3 / rho
v_square = v1^2 + v2^2 + v3^2

return (equations.gamma - 1) *
SVector(0.5f0 * v_square, -v1, -v2, -v3, 1, -B1, -B2, -B3, -psi)
end
Copy link
Contributor Author

@bennibolm bennibolm Sep 24, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same code is used in 2d.
How is that even working in 2d? u with 9 components including v1, v2 AND v3? @amrueda

Copy link
Contributor Author

@bennibolm bennibolm Sep 24, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But that's how it is in main (see here)

Copy link
Contributor Author

@bennibolm bennibolm Sep 24, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do IdealGlmMhdEquations2D and IdealGlmMhdEquations3D have the same variables? Sounds somehow wrong to me. Or is it just implemented like this in Trixi? @amrueda

@bennibolm bennibolm force-pushed the 3d-subcell-limiting branch 2 times, most recently from 84712c8 to 1911c38 Compare October 23, 2025 12:20
@bennibolm bennibolm force-pushed the 3d-subcell-limiting branch from 1911c38 to 691c88f Compare October 27, 2025 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@amrueda amrueda amrueda left review comments

@JoshuaLampert JoshuaLampert JoshuaLampert requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@bennibolm @DanielDoehring @amrueda @JoshuaLampert @ranocha