-
Couldn't load subscription status.
- Fork 131
Viscous CFL 2D 3D TreeMesh
#2586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Viscous CFL 2D 3D TreeMesh
#2586
Conversation
TreeMeshTreeMesh
Review checklistThis checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging. Purpose and scope
Code quality
Documentation
Testing
Performance
Verification
Created with ❤️ by the Trixi.jl community. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2586 +/- ##
=======================================
Coverage 96.80% 96.81%
=======================================
Files 530 532 +2
Lines 42719 42801 +82
=======================================
+ Hits 41354 41434 +80
- Misses 1365 1367 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This extends #2035 to 2D and 3D TreeMeshes. P4est is supposed to follow in a different PR.
This version implements the CFL criterion only for isotropic diffusive terms, which is fine for the diffusion and NSF equations currently implemented. Thus, this does not work for anisotropic diffusion as in the example
https://trixi-framework.github.io/TrixiDocumentation/stable/tutorials/adding_new_parabolic_terms/#Define-a-new-parabolic-equation-type
See also #2035 (comment)
What we want is an open question.
xref #1147