Skip to content

Conversation

@DanielDoehring
Copy link
Member

@DanielDoehring DanielDoehring commented Sep 25, 2025

This extends #2035 to 2D and 3D TreeMeshes. P4est is supposed to follow in a different PR.

This version implements the CFL criterion only for isotropic diffusive terms, which is fine for the diffusion and NSF equations currently implemented. Thus, this does not work for anisotropic diffusion as in the example

https://trixi-framework.github.io/TrixiDocumentation/stable/tutorials/adding_new_parabolic_terms/#Define-a-new-parabolic-equation-type

See also #2035 (comment)

What we want is an open question.

xref #1147

@DanielDoehring DanielDoehring added the enhancement New feature or request label Sep 25, 2025
@DanielDoehring DanielDoehring changed the title Viscous CFL 2Dd 3D TreeMesh Viscous CFL 2D 3D TreeMesh Sep 25, 2025
@github-actions
Copy link
Contributor

Review checklist

This checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging.

Purpose and scope

  • The PR has a single goal that is clear from the PR title and/or description.
  • All code changes represent a single set of modifications that logically belong together.
  • No more than 500 lines of code are changed or there is no obvious way to split the PR into multiple PRs.

Code quality

  • The code can be understood easily.
  • Newly introduced names for variables etc. are self-descriptive and consistent with existing naming conventions.
  • There are no redundancies that can be removed by simple modularization/refactoring.
  • There are no leftover debug statements or commented code sections.
  • The code adheres to our conventions and style guide, and to the Julia guidelines.

Documentation

  • New functions and types are documented with a docstring or top-level comment.
  • Relevant publications are referenced in docstrings (see example for formatting).
  • Inline comments are used to document longer or unusual code sections.
  • Comments describe intent ("why?") and not just functionality ("what?").
  • If the PR introduces a significant change or new feature, it is documented in NEWS.md with its PR number.

Testing

  • The PR passes all tests.
  • New or modified lines of code are covered by tests.
  • New or modified tests run in less then 10 seconds.

Performance

  • There are no type instabilities or memory allocations in performance-critical parts.
  • If the PR intent is to improve performance, before/after time measurements are posted in the PR.

Verification

  • The correctness of the code was verified using appropriate tests.
  • If new equations/methods are added, a convergence test has been run and the results
    are posted in the PR.

Created with ❤️ by the Trixi.jl community.

@codecov
Copy link

codecov bot commented Sep 25, 2025

Codecov Report

❌ Patch coverage is 97.64706% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 96.81%. Comparing base (8b53969) to head (fbe2fc0).
⚠️ Report is 16 commits behind head on main.

Files with missing lines Patch % Lines
src/callbacks_step/stepsize_dg2d.jl 92.31% 1 Missing ⚠️
src/callbacks_step/stepsize_dg3d.jl 92.31% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2586   +/-   ##
=======================================
  Coverage   96.80%   96.81%           
=======================================
  Files         530      532    +2     
  Lines       42719    42801   +82     
=======================================
+ Hits        41354    41434   +80     
- Misses       1365     1367    +2     
Flag Coverage Δ
unittests 96.81% <97.65%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant