Skip to content

Conversation

@SimonCan
Copy link
Contributor

@SimonCan SimonCan commented Oct 9, 2025

Added capability of coupling pest mesh views with hanging/non-conforming nodes.

SimonCan and others added 30 commits April 30, 2025 14:08
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Removed redundant code from structured mesh coupled semidiscretization.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SimonCan and others added 13 commits October 9, 2025 07:26
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@SimonCan SimonCan added enhancement New feature or request low-priority labels Oct 9, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2025

Review checklist

This checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging.

Purpose and scope

  • The PR has a single goal that is clear from the PR title and/or description.
  • All code changes represent a single set of modifications that logically belong together.
  • No more than 500 lines of code are changed or there is no obvious way to split the PR into multiple PRs.

Code quality

  • The code can be understood easily.
  • Newly introduced names for variables etc. are self-descriptive and consistent with existing naming conventions.
  • There are no redundancies that can be removed by simple modularization/refactoring.
  • There are no leftover debug statements or commented code sections.
  • The code adheres to our conventions and style guide, and to the Julia guidelines.

Documentation

  • New functions and types are documented with a docstring or top-level comment.
  • Relevant publications are referenced in docstrings (see example for formatting).
  • Inline comments are used to document longer or unusual code sections.
  • Comments describe intent ("why?") and not just functionality ("what?").
  • If the PR introduces a significant change or new feature, it is documented in NEWS.md with its PR number.

Testing

  • The PR passes all tests.
  • New or modified lines of code are covered by tests.
  • New or modified tests run in less then 10 seconds.

Performance

  • There are no type instabilities or memory allocations in performance-critical parts.
  • If the PR intent is to improve performance, before/after time measurements are posted in the PR.

Verification

  • The correctness of the code was verified using appropriate tests.
  • If new equations/methods are added, a convergence test has been run and the results
    are posted in the PR.

Created with ❤️ by the Trixi.jl community.

Comment on lines +13 to +18
x1, x2 = x
v1 = 0.0
v2 = 0.0
b = 0.0
H = 1.0
return prim2cons(SVector(H, v1, v2, b), equations)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[JuliaFormatter] reported by reviewdog 🐶

Suggested change
x1, x2 = x
v1 = 0.0
v2 = 0.0
b = 0.0
H = 1.0
return prim2cons(SVector(H, v1, v2, b), equations)
x1, x2 = x
v1 = 0.0
v2 = 0.0
b = 0.0
H = 1.0
return prim2cons(SVector(H, v1, v2, b), equations)

end

initial_condition = initial_condition_test

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[JuliaFormatter] reported by reviewdog 🐶

Suggested change

@codecov
Copy link

codecov bot commented Oct 16, 2025

Codecov Report

❌ Patch coverage is 4.91453% with 445 lines in your changes missing coverage. Please review.
✅ Project coverage is 94.54%. Comparing base (d52e08d) to head (2b94b79).

Files with missing lines Patch % Lines
...discretization/semidiscretization_coupled_p4est.jl 0.00% 211 Missing ⚠️
src/meshes/p4est_mesh_view.jl 0.00% 88 Missing ⚠️
src/solvers/dgsem_p4est/dg_2d.jl 0.00% 60 Missing ⚠️
src/solvers/dgsem_tree/dg_2d.jl 26.32% 28 Missing ⚠️
...xamples/p4est_2d_dgsem/elixir_euler_mhd_coupled.jl 0.00% 21 Missing ⚠️
src/solvers/dgsem_unstructured/dg_2d.jl 0.00% 14 Missing ⚠️
...emidiscretization/semidiscretization_hyperbolic.jl 0.00% 9 Missing ⚠️
examples/structured_2d_dgsem/test.jl 0.00% 7 Missing ⚠️
...xamples/p4est_2d_dgsem/elixir_advection_coupled.jl 0.00% 5 Missing ⚠️
src/solvers/dgsem_p4est/dg.jl 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2598      +/-   ##
==========================================
- Coverage   96.81%   94.54%   -2.27%     
==========================================
  Files         533      537       +4     
  Lines       42804    43247     +443     
==========================================
- Hits        41438    40887     -551     
- Misses       1366     2360     +994     
Flag Coverage Δ
unittests 94.54% <4.91%> (-2.27%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

SimonCan and others added 8 commits October 17, 2025 09:42
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request low-priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants