-
Notifications
You must be signed in to change notification settings - Fork 3
Add unit and type tests #117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #117 +/- ##
==========================================
+ Coverage 91.89% 96.88% +4.98%
==========================================
Files 28 28
Lines 3073 3369 +296
==========================================
+ Hits 2824 3264 +440
+ Misses 249 105 -144 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ranocha
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Could you please also add some type stability tests like in https://github.com/trixi-framework/Trixi.jl/blob/main/test/test_type.jl?
|
Since it looks like this PR will become big: You don't have to add these tests for everything. It is also fine to add them for some equations and open an issue for the remaining ones. |
|
Sorry, I didn't realize it became that big. I tried to cover as much as possible. Some of the equations are still not fully tested (e.g. Moist and CovariantShallowWater), therefore I'll open an issue after this PR will be merged. If you prefer I can divide this PR in a couple of PRs. Otherwise this is ready for a review. |
|
Thanks! You can already open the issue. |
ranocha
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
examples/elixir_euler_potential_temperature_baroclinic_instability.jl
Outdated
Show resolved
Hide resolved
ranocha
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! It would be nice to get a review from one of the other developers as well, e.g., @amrueda, @benegee, or @tristanmontoya
benegee
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for putting so much effort into this! It is great to see such thorough unit tests and will be a perfect guideline for upcoming implementation. I will myself try to follow in #100.
Following #114, this PR adds unit and type stability tests.