Skip to content

Conversation

@MarcoArtiano
Copy link
Collaborator

@MarcoArtiano MarcoArtiano commented Oct 2, 2025

Following #114, this PR adds unit and type stability tests.

@MarcoArtiano MarcoArtiano changed the title WP: Add unit tests WIP: Add unit tests Oct 2, 2025
@codecov
Copy link

codecov bot commented Oct 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.88%. Comparing base (9dd3b48) to head (aa421ab).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #117      +/-   ##
==========================================
+ Coverage   91.89%   96.88%   +4.98%     
==========================================
  Files          28       28              
  Lines        3073     3369     +296     
==========================================
+ Hits         2824     3264     +440     
+ Misses        249      105     -144     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MarcoArtiano MarcoArtiano changed the title WIP: Add unit tests Add unit tests Oct 2, 2025
@MarcoArtiano MarcoArtiano marked this pull request as ready for review October 2, 2025 11:39
@ranocha ranocha linked an issue Oct 2, 2025 that may be closed by this pull request
Copy link
Member

@ranocha ranocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Could you please also add some type stability tests like in https://github.com/trixi-framework/Trixi.jl/blob/main/test/test_type.jl?

@ranocha
Copy link
Member

ranocha commented Oct 7, 2025

Since it looks like this PR will become big: You don't have to add these tests for everything. It is also fine to add them for some equations and open an issue for the remaining ones.
(I should have written this earlier, sorry)

@MarcoArtiano
Copy link
Collaborator Author

MarcoArtiano commented Oct 7, 2025

Sorry, I didn't realize it became that big. I tried to cover as much as possible.

Some of the equations are still not fully tested (e.g. Moist and CovariantShallowWater), therefore I'll open an issue after this PR will be merged.

If you prefer I can divide this PR in a couple of PRs. Otherwise this is ready for a review.

@ranocha
Copy link
Member

ranocha commented Oct 8, 2025

Thanks! You can already open the issue.

Copy link
Member

@ranocha ranocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MarcoArtiano MarcoArtiano changed the title Add unit tests Add unit and type tests Oct 8, 2025
ranocha
ranocha previously approved these changes Oct 9, 2025
Copy link
Member

@ranocha ranocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! It would be nice to get a review from one of the other developers as well, e.g., @amrueda, @benegee, or @tristanmontoya

benegee
benegee previously approved these changes Oct 9, 2025
Copy link
Collaborator

@benegee benegee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for putting so much effort into this! It is great to see such thorough unit tests and will be a perfect guideline for upcoming implementation. I will myself try to follow in #100.

@MarcoArtiano MarcoArtiano dismissed stale reviews from benegee and ranocha via aa421ab October 9, 2025 13:41
@benegee benegee merged commit 9d6bbf5 into main Oct 9, 2025
10 checks passed
@benegee benegee deleted the test_unit branch October 9, 2025 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add unit and type stability tests

4 participants