Skip to content

Conversation

@MarcoArtiano
Copy link
Collaborator

@MarcoArtiano MarcoArtiano commented Oct 17, 2025

This PR adds the 2D compressible Euler Equations with gravity where the prognostic variables are density, momentum and kinetic plus internal energy, instead of the total energy as in #79.

I have few questions about the name, at the moment I decided for CompressibleEulerInternalKineticEnergyEquationsWithGravity2D, however I'm not sure whether this is the best option, to differentiate it by CompressibleEulerEquationsWithGravity2D where the total energy is the prognostic variable.

Other suggestions may be:
CompressibleEulerInternalAndKineticEnergyEquationsWithGravity2D
CompressibleEulerKineticInternalEnergyEquationsWithGravity2D
CompressibleEulerKineticAndInternalEquationsWithGravity2D

Do you have any suggestions @benegee, @tristanmontoya, @amrueda?

Hendrik suggested CompressibleEulerEnergyEquationsWithGravity2D.

  • Add type tests
  • Add inertia gravity wave and test

To do in new PRs:

  • Add baroclinic instability
  • Add mountain Schaer
  • Add linear hydrostatic
  • Add linear nonhydrostatic

@codecov
Copy link

codecov bot commented Oct 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.10%. Comparing base (9d6bbf5) to head (80cebe5).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #119      +/-   ##
==========================================
+ Coverage   96.88%   97.10%   +0.21%     
==========================================
  Files          28       29       +1     
  Lines        3369     3621     +252     
==========================================
+ Hits         3264     3516     +252     
  Misses        105      105              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MarcoArtiano MarcoArtiano changed the title WIP: Add 2D Compressible Euler with Gravity Add 2D Compressible Euler with Gravity Oct 20, 2025
@MarcoArtiano MarcoArtiano marked this pull request as ready for review October 20, 2025 12:33
Copy link
Member

@ranocha ranocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just a minor round of comments.

@MarcoArtiano
Copy link
Collaborator Author

@ranocha I've changed the name accordingly and added the comment. This is ready for the final round of review. Thanks!

Copy link
Member

@ranocha ranocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ranocha ranocha merged commit c4b57ee into main Oct 23, 2025
10 checks passed
@ranocha ranocha deleted the ma/euler_with_gravity branch October 23, 2025 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants