Use at-test_trixi_include for consistency tests with Trixi.jl#145
Merged
Use at-test_trixi_include for consistency tests with Trixi.jl#145
Conversation
Member
|
So, it looks like we do not get the previous error anymore, but now a different one. I think this should be fixed by declaring |
JoshuaLampert
requested changes
Feb 4, 2026
Member
|
Now we get yet another error. I think, we have to remove the |
Member
Author
|
I am not sure this is worth all the time |
Member
Yeah, I agree, but I also like finishing PRs and verifying hypotheses, so I gave it another try 😅 |
…TrixiAtmo.jl into ranocha-patch-1
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #145 +/- ##
=======================================
Coverage 97.10% 97.10%
=======================================
Files 33 33
Lines 4558 4558
=======================================
Hits 4426 4426
Misses 132 132 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let's see whether @JoshuaLampert's idea from #144 (comment) works.