Skip to content

Use at-test_trixi_include for consistency tests with Trixi.jl#145

Merged
ranocha merged 6 commits intomainfrom
ranocha-patch-1
Feb 5, 2026
Merged

Use at-test_trixi_include for consistency tests with Trixi.jl#145
ranocha merged 6 commits intomainfrom
ranocha-patch-1

Conversation

@ranocha
Copy link
Copy Markdown
Member

@ranocha ranocha commented Feb 4, 2026

Let's see whether @JoshuaLampert's idea from #144 (comment) works.

@ranocha ranocha added the testing label Feb 4, 2026
@JoshuaLampert
Copy link
Copy Markdown
Member

So, it looks like we do not get the previous error anymore, but now a different one. I think this should be fixed by declaring maxiters global.

@JoshuaLampert
Copy link
Copy Markdown
Member

Now we get yet another error. I think, we have to remove the Main. in front of the variables defined in the elixir.

@ranocha
Copy link
Copy Markdown
Member Author

ranocha commented Feb 4, 2026

I am not sure this is worth all the time

@JoshuaLampert
Copy link
Copy Markdown
Member

I am not sure this is worth all the time

Yeah, I agree, but I also like finishing PRs and verifying hypotheses, so I gave it another try 😅

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.10%. Comparing base (1c6a19c) to head (d5b04ca).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #145   +/-   ##
=======================================
  Coverage   97.10%   97.10%           
=======================================
  Files          33       33           
  Lines        4558     4558           
=======================================
  Hits         4426     4426           
  Misses        132      132           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Member

@JoshuaLampert JoshuaLampert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now👍

@ranocha
Copy link
Copy Markdown
Member Author

ranocha commented Feb 5, 2026

Thanks!

@ranocha ranocha merged commit 466e619 into main Feb 5, 2026
10 checks passed
@ranocha ranocha deleted the ranocha-patch-1 branch February 5, 2026 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants